mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>
Cc: Cheng Yongkang <teel4res@gmail.com>,
	David Sterba <dsterba@suse.com>, Chris Mason <mason@kernel.org>,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: reject refs=0 subvolume without DEAD in SUBVOL_SYNC_WAIT
Date: Sat, 14 Nov 2026 10:03:52 +1030	[thread overview]
Message-ID: <e3b11819-77e7-460c-9e87-06ae6af7cce9@gmx.com> (raw)
In-Reply-To: <20261113163049.GA49432@suse.cz>



在 2026/11/14 03:00, David Sterba 写道:
> On Tue, Nov 10, 2026 at 07:00:34AM +1030, Qu Wenruo wrote:
>>
>>
>> 在 2026/11/10 05:17, David Sterba 写道:
>>> On Sun, Nov 01, 2026 at 05:48:21PM +1030, Qu Wenruo wrote:
>>>> With that said, there are more problems with the ioctl.
>>>>
>>>> - No real user
>>>>      No one is utilizing BTRFS_SUBVOL_SYNC* flags. Btrfs-progs itself
>>>>      doesn't even bother it.
>>>>
>>>>      So all these fixes are very low priority, unless there are some wild
>>>>      programs utilizing this.
>>>>
>>>>      But even btrfs-progs doesn't utilize them, the possibility are very
>>>>      low.
>>>
>>> Obviously the ioctl was added so progs 'subvol sync' can use it for
>>> non-root users. I started working on it but there's a problem with the
>>> behaviour change between the user types. Root has full access and
>>> reports the progress while with this ioctl there were some problems I
>>> don't remember. The ioctl was designed to emulate all modes that root
>>> can do so it should be possible to get 1:1 output.
>>
>> Are you still planning to implement the full root-less subvolume wait in
>> progs?
> 
> Yes, but I don't have an ETA.
> 
>> Or is this feature deprecated and we can eventually remove it to reduce
>> LLM bug reports?
> 
> I don't understand what would need to be deprecated, it's a new ioctl
> missing the userspace counterpart to implement an unprivileged
> functionality where it makes sense.

Then at least hide it under experimental features until the user space 
counter part is in a good shape, so that no random LLM report or syzbot 
steps into this ioctl?

      reply	other threads:[~2026-11-13 23:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-01  6:25 Cheng Yongkang
2026-11-01  6:51 ` Qu Wenruo
2026-11-01  7:18   ` Qu Wenruo
2026-11-01  7:33     ` Cheng Yongkang
2026-11-01  8:27       ` Qu Wenruo
2026-11-09 18:47     ` David Sterba
2026-11-09 20:30       ` Qu Wenruo
2026-11-13 16:30         ` David Sterba
2026-11-13 23:33           ` Qu Wenruo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3b11819-77e7-460c-9e87-06ae6af7cce9@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=teel4res@gmail.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®