mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Thomas Weißschuh" <linux@weissschuh.net>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
	linux-kbuild@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-doc@vger.kernel.org, Nathan Chancellor <nathan@kernel.org>,
	 Nicolas Schier <nicolas@fjasle.eu>,
	Jonathan Corbet <corbet@lwn.net>,
	 Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
	 Ben Hutchings <ben@decadent.org.uk>,
	Peter Oberparleiter <oberpar@linux.ibm.com>,
	 MPTCP Linux <mptcp@lists.linux.dev>
Subject: Re: [PATCH v2] kbuild: make all file references relative to source root
Date: Thu, 1 May 2025 18:48:52 +0200	[thread overview]
Message-ID: <e3ccb1ef-1b7a-4069-960f-a6fc5353c1ce@t-8ch.de> (raw)
In-Reply-To: <edc50aa7-0740-4942-8c15-96f12f2acc7e@kernel.org>

Hi Matthieu,

On 2025-04-29 18:12:29+0200, Matthieu Baerts wrote:
> Hi Thomas, Masahiro,
> 
> +Cc Peter Oberparleiter, MPTCP ML
> 
> On 15/03/2025 14:20, Thomas Weißschuh wrote:
> > -fmacro-prefix-map only affects __FILE__ and __BASE_FILE__.
> > Other references, for example in debug information, are not affected.
> > This makes handling of file references in the compiler outputs harder to
> > use and creates problems for reproducible builds.
> > 
> > Switch to -ffile-prefix map which affects all references.
> > 
> > Also drop the documentation section advising manual specification of
> > -fdebug-prefix-map for reproducible builds, as it is not necessary
> > anymore.
> > 
> > Suggested-by: Ben Hutchings <ben@decadent.org.uk>
> > Link: https://lore.kernel.org/lkml/c49cc967294f9a3a4a34f69b6a8727a6d3959ed8.camel@decadent.org.uk/
> > Acked-by: Borislav Petkov (AMD) <bp@alien8.de> # arch/x86/
> > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> 
> Thank you for having worked on that!
> 
> (...)
> 
> > diff --git a/Makefile b/Makefile
> > index 5c333682dc9142b1aacfe454a5c77f5923554b7d..4f920187cee658ae4d1b807fca365f6994274828 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -1067,7 +1067,7 @@ endif
> >  
> >  # change __FILE__ to the relative path to the source directory
> >  ifdef building_out_of_srctree
> > -KBUILD_CPPFLAGS += $(call cc-option,-fmacro-prefix-map=$(srcroot)/=)
> > +KBUILD_CPPFLAGS += $(call cc-option,-ffile-prefix-map=$(srcroot)/=)
> >  KBUILD_RUSTFLAGS += --remap-path-prefix=$(srcroot)/=
> >  endif
> 
> Today, I noticed that my CI for the MPTCP subsystem couldn't produce
> code coverage files like before: the source files are not found. A 'git
> bisect' pointed me to this patch. Reverting it seems to fix the issue.
> 
> 
> My CI is building the kernel out of the source tree, in ".virtme/build".
> Before and after this patch, GCOV seems to do its job properly.
> Capturing GCOV data with this lcov command seems OK too:
> 
>   lcov --capture --keep-going -j "${INPUT_CPUS}" \
>      --rc geninfo_unexecuted_blocks=1 \
>      --include '/net/mptcp/' \
>      --function-coverage --branch-coverage \
>      -b "${PWD}/.virtme/build" -o kernel.lcov
> 
> But after this patch, lcov complains some files are not found, e.g.
> 
>   ERROR: (source) unable to open
> ${WORKDIR}/.virtme/build/net/mptcp/ctrl.c: No such file or directory
> 
> 
> The output file is different: the path to the source file is wrong
> because it points to the build dir. Instead of ...
> 
>   SF:${WORKDIR}/net/mptcp/ctrl.c
> 
> ... now I have ...
> 
>   SF:${WORKDIR}/.virtme/build/net/mptcp/ctrl.c
> 
> 
> Are there modifications needed on GCOV side to adapt to the behaviour
> change introduced by this patch? Or something else needed on the
> userspace side?

I'd like to focus on the report from Ville Syrjälä [0] first.
While it is easier to reproduce and investigate, I suspect the solution
found there will also work for your usecase.


Thomas

[0] https://lore.kernel.org/lkml/aBEttQH4kimHFScx@intel.com/

  reply	other threads:[~2025-05-01 16:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-15 13:20 Thomas Weißschuh
2025-03-16  2:06 ` Masahiro Yamada
2025-03-16 19:08 ` Ben Hutchings
2025-03-17 17:17   ` Nathan Chancellor
2025-04-29 16:12 ` Matthieu Baerts
2025-05-01 16:48   ` Thomas Weißschuh [this message]
2025-05-02 11:33   ` Peter Oberparleiter
2025-04-29 19:51 ` Ville Syrjälä
2025-05-05  7:30   ` Thomas Weißschuh
2025-05-11  3:37     ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3ccb1ef-1b7a-4069-960f-a6fc5353c1ce@t-8ch.de \
    --to=linux@weissschuh.net \
    --cc=ben@decadent.org.uk \
    --cc=bp@alien8.de \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mptcp@lists.linux.dev \
    --cc=nathan@kernel.org \
    --cc=nicolas@fjasle.eu \
    --cc=oberpar@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®