* [PATCH v2] virtio-vdpa: Drop redundant conversion to bool
@ 2025-08-18 10:00 Xichao Zhao
2025-08-18 10:13 ` Eugenio Perez Martin
0 siblings, 1 reply; 3+ messages in thread
From: Xichao Zhao @ 2025-08-18 10:00 UTC (permalink / raw)
To: mst, jasowang
Cc: xuanzhuo, eperezma, virtualization, linux-kernel, Xichao Zhao
The result of integer comparison already evaluates to bool. No need for
explicit conversion.
Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
---
drivers/virtio/virtio_vdpa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
index 657b07a60788..09ee81470323 100644
--- a/drivers/virtio/virtio_vdpa.c
+++ b/drivers/virtio/virtio_vdpa.c
@@ -176,7 +176,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
if (ops->get_vq_num_min)
min_num = ops->get_vq_num_min(vdpa);
- may_reduce_num = (max_num == min_num) ? false : true;
+ may_reduce_num = !(max_num == min_num);
/* Create the vring */
align = ops->get_vq_align(vdpa);
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] virtio-vdpa: Drop redundant conversion to bool
2025-08-18 10:00 [PATCH v2] virtio-vdpa: Drop redundant conversion to bool Xichao Zhao
@ 2025-08-18 10:13 ` Eugenio Perez Martin
2025-08-18 10:25 ` 赵西超
0 siblings, 1 reply; 3+ messages in thread
From: Eugenio Perez Martin @ 2025-08-18 10:13 UTC (permalink / raw)
To: Xichao Zhao; +Cc: mst, jasowang, xuanzhuo, virtualization, linux-kernel
On Mon, Aug 18, 2025 at 12:01 PM Xichao Zhao <zhao.xichao@vivo.com> wrote:
>
> The result of integer comparison already evaluates to bool. No need for
> explicit conversion.
>
> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
> ---
> drivers/virtio/virtio_vdpa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
> index 657b07a60788..09ee81470323 100644
> --- a/drivers/virtio/virtio_vdpa.c
> +++ b/drivers/virtio/virtio_vdpa.c
> @@ -176,7 +176,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
> if (ops->get_vq_num_min)
> min_num = ops->get_vq_num_min(vdpa);
>
> - may_reduce_num = (max_num == min_num) ? false : true;
> + may_reduce_num = !(max_num == min_num);
What about max_num != min_num ?
>
> /* Create the vring */
> align = ops->get_vq_align(vdpa);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] virtio-vdpa: Drop redundant conversion to bool
2025-08-18 10:13 ` Eugenio Perez Martin
@ 2025-08-18 10:25 ` 赵西超
0 siblings, 0 replies; 3+ messages in thread
From: 赵西超 @ 2025-08-18 10:25 UTC (permalink / raw)
To: Eugenio Perez Martin
Cc: mst, jasowang, xuanzhuo, virtualization, linux-kernel
> On Mon, Aug 18, 2025 at 12:01 PM Xichao Zhao <zhao.xichao@vivo.com> wrote:
>> The result of integer comparison already evaluates to bool. No need for
>> explicit conversion.
>>
>> Signed-off-by: Xichao Zhao <zhao.xichao@vivo.com>
>> ---
>> drivers/virtio/virtio_vdpa.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/virtio/virtio_vdpa.c b/drivers/virtio/virtio_vdpa.c
>> index 657b07a60788..09ee81470323 100644
>> --- a/drivers/virtio/virtio_vdpa.c
>> +++ b/drivers/virtio/virtio_vdpa.c
>> @@ -176,7 +176,7 @@ virtio_vdpa_setup_vq(struct virtio_device *vdev, unsigned int index,
>> if (ops->get_vq_num_min)
>> min_num = ops->get_vq_num_min(vdpa);
>>
>> - may_reduce_num = (max_num == min_num) ? false : true;
>> + may_reduce_num = !(max_num == min_num);
> What about max_num != min_num ?
Yes, I agree. I am preparing to modify it and send a v3 version.Thank you.
Best regards,
Xichao Zhao
>> /* Create the vring */
>> align = ops->get_vq_align(vdpa);
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-18 10:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-08-18 10:00 [PATCH v2] virtio-vdpa: Drop redundant conversion to bool Xichao Zhao
2025-08-18 10:13 ` Eugenio Perez Martin
2025-08-18 10:25 ` 赵西超
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®