From: Reinette Chatre <reinette.chatre@intel.com>
To: Aaron Tomlin <atomlin@atomlin.com>, <tony.luck@intel.com>,
<Dave.Martin@arm.com>, <james.morse@arm.com>,
<babu.moger@amd.com>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>
Cc: <sean@ashe.io>, <neelx@suse.com>, <mproche@gmail.com>,
<chjohnst@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc_cbm
Date: Wed, 1 Apr 2026 10:27:51 -0700 [thread overview]
Message-ID: <e3e695f4-de6c-4629-aa26-746759bf8c7c@intel.com> (raw)
In-Reply-To: <20260325001159.447075-2-atomlin@atomlin.com>
Hi Aaron,
On 3/24/26 5:11 PM, Aaron Tomlin wrote:
> The last_cmd_status file is intended to report details about the most
> recent resctrl filesystem operation, specifically to aid in diagnosing
> failures.
>
> However, when parsing io_alloc_cbm, if a user provides a domain ID that
> does not exist in the resource, the operation fails with -EINVAL without
> updating last_cmd_status. This results in inconsistent behaviour where
> the system call returns an error, but last_cmd_status misleadingly reports
> "ok", leaving the user unaware that the failure was caused by an invalid
> domain ID.
>
> Write an error message to last_cmd_status when the target domain ID cannot
> be found.
>
> Fixes: 28fa2cce7a83 ("fs/resctrl: Introduce interface to modify io_alloc capacity bitmasks")
> Suggested-by: Reinette Chatre <reinette.chatre@intel.com>
> Signed-off-by: Aaron Tomlin <atomlin@atomlin.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
next prev parent reply other threads:[~2026-04-01 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 0:11 [PATCH v6 0/2] fs/resctrl: Add "*" shorthand to set io_alloc CBM for all domains Aaron Tomlin
2026-03-25 0:11 ` [PATCH v6 1/2] fs/resctrl: Report invalid domain ID when parsing io_alloc_cbm Aaron Tomlin
2026-04-01 17:27 ` Reinette Chatre [this message]
2026-04-01 22:35 ` [tip: x86/cache] " tip-bot2 for Aaron Tomlin
2026-03-25 0:11 ` [PATCH v6 2/2] fs/resctrl: Add "*" shorthand to set io_alloc CBM for all domains Aaron Tomlin
2026-04-01 17:28 ` Reinette Chatre
2026-04-01 22:35 ` [tip: x86/cache] " tip-bot2 for Aaron Tomlin
2026-03-27 0:23 ` [PATCH v6 0/2] " Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3e695f4-de6c-4629-aa26-746759bf8c7c@intel.com \
--to=reinette.chatre@intel.com \
--cc=Dave.Martin@arm.com \
--cc=atomlin@atomlin.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chjohnst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mproche@gmail.com \
--cc=neelx@suse.com \
--cc=sean@ashe.io \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®