mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>,
	Ben Chuang <ben.chuang@genesyslogic.com.tw>,
	Victor Shih <victor.shih@genesyslogic.com.tw>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci-pci-gli: Fix GL9767 s0ix sleep blocking
Date: Mon, 25 May 2026 08:26:00 +0300	[thread overview]
Message-ID: <e3ed4446-ffcd-4b05-86af-2db763419bf4@intel.com> (raw)
In-Reply-To: <19e5009d987.8379fb8938306.7573506608157081813@zohomail.in>

+ Ben and Victor

On 22/05/2026 17:14, Ashwin Gundarapu wrote:
> From 42b314da9b13f5aad38c7a58bc4191b08d6b2156 Mon Sep 17 00:00:00 2001
> From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> Date: Fri, 22 May 2026 19:39:12 +0530
> Subject: [PATCH] mmc: sdhci-pci-gli: Fix GL9767 s0ix sleep blocking
> 
> Add missing suspend callback for GL9767 chip. Without this, the
> SD card reader remains active during system suspend, preventing
> the CPU from entering low-power s0ix states.
> 
> Use the same suspend function as GL9763e, which properly powers
> down the device during suspend.
> 
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219284
> Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> ---
>  drivers/mmc/host/sdhci-pci-gli.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index 6e4084407662..b6251cdde228 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -2121,13 +2121,14 @@ static const struct sdhci_ops sdhci_gl9767_ops = {
>  };
> 
>  const struct sdhci_pci_fixes sdhci_gl9767 = {
> -	.quirks		= SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> -	.quirks2	= SDHCI_QUIRK2_BROKEN_DDR50,
> -	.probe_slot	= gli_probe_slot_gl9767,
> -	.add_host	= sdhci_pci_uhs2_add_host,
> -	.remove_host	= sdhci_pci_uhs2_remove_host,
> -	.ops		= &sdhci_gl9767_ops,
> +        .quirks         = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> +        .quirks2        = SDHCI_QUIRK2_BROKEN_DDR50,
> +        .probe_slot     = gli_probe_slot_gl9767,
> +        .add_host       = sdhci_pci_uhs2_add_host,
> +        .remove_host    = sdhci_pci_uhs2_remove_host,
> +        .ops            = &sdhci_gl9767_ops,
>  #ifdef CONFIG_PM_SLEEP
> -	.resume		= sdhci_pci_gli_resume,
> +        .suspend        = gl9763e_suspend,
> +        .resume         = sdhci_pci_gli_resume,
>  #endif
> -};
> +};
> \ No newline at end of file
> --
> 2.43.0
> 
> 


  reply	other threads:[~2026-05-25  5:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 14:14 Ashwin Gundarapu
2026-05-25  5:26 ` Adrian Hunter [this message]
2026-05-29  8:32   ` BenChuang[莊智量]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3ed4446-ffcd-4b05-86af-2db763419bf4@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=ben.chuang@genesyslogic.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linuxuser509@zohomail.in \
    --cc=victor.shih@genesyslogic.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome