* RE: [PATCH] mmc: sdhci-pci-gli: Fix GL9767 s0ix sleep blocking
2026-05-25 5:26 ` Adrian Hunter
@ 2026-05-29 8:32 ` BenChuang[莊智量]
0 siblings, 0 replies; 3+ messages in thread
From: BenChuang[莊智量] @ 2026-05-29 8:32 UTC (permalink / raw)
To: Ashwin Gundarapu, Victor Shih
Cc: Adrian Hunter, linux-kernel, linux-mmc, benchuanggli
> -----Original Message-----
> From: Adrian Hunter <adrian.hunter@intel.com>
> Sent: Monday, May 25, 2026 1:26 PM
> To: Ashwin Gundarapu <linuxuser509@zohomail.in>; BenChuang[莊智量] <Ben.Chuang@genesyslogic.com.tw>; Victor Shih
> <victor.shih@genesyslogic.com.tw>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>; linux-mmc <linux-mmc@vger.kernel.org>
> Subject: Re: [PATCH] mmc: sdhci-pci-gli: Fix GL9767 s0ix sleep blocking
>
> + Ben and Victor
>
> On 22/05/2026 17:14, Ashwin Gundarapu wrote:
> > From 42b314da9b13f5aad38c7a58bc4191b08d6b2156 Mon Sep 17 00:00:00 2001
> > From: Ashwin Gundarapu <linuxuser509@zohomail.in>
> > Date: Fri, 22 May 2026 19:39:12 +0530
> > Subject: [PATCH] mmc: sdhci-pci-gli: Fix GL9767 s0ix sleep blocking
> >
> > Add missing suspend callback for GL9767 chip. Without this, the
> > SD card reader remains active during system suspend, preventing
> > the CPU from entering low-power s0ix states.
> >
> > Use the same suspend function as GL9763e, which properly powers
> > down the device during suspend.
> >
Hi Ashwin,
Thanks for sharing this change.
This approach generally looks reasonable, but I have a few questions.
Could you help provide some additional context on which path may
cause the LPM negotiation to remain inactive on GL9767? It would
be helpful to better understand whether there might be any chip-specific
handling involved in the suspend flow.
GL9763E and GL9767 may have some differences, and the gl9763e_suspend
callback may not always directly apply to GL9767. I do have access to
a GL9767 device; however, it is likely on a different platform, so I
may not be able to verify this behavior under the same conditions.
Any additional details you could share would be greatly appreciated.
Before moving forward, could you please provide more information on
your validation? For example:
- Test platform
- Steps to reproduce the issue and verify the fix
- dmesg logs covering suspend/resume before and after this patch
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=21928
> > 4&data=05%7C02%7Cben.chuang%40genesyslogic.com.tw%7C01d5e14d468340b49b0808deba1e220e%7C4e753840bf6b40
> > a19645185818deeb52%7C0%7C0%7C639152835758567322%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWU
> > sIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=0Ue1kdd9s7qbKyJ
> > fLkZlPuOWtZJWCnna0LTAmiG5lcg%3D&reserved=0
> > Signed-off-by: Ashwin Gundarapu <linuxuser509@zohomail.in>
> > ---
> > drivers/mmc/host/sdhci-pci-gli.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index 6e4084407662..b6251cdde228 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -2121,13 +2121,14 @@ static const struct sdhci_ops sdhci_gl9767_ops = {
> > };
> >
> > const struct sdhci_pci_fixes sdhci_gl9767 = {
> > - .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> > - .quirks2 = SDHCI_QUIRK2_BROKEN_DDR50,
> > - .probe_slot = gli_probe_slot_gl9767,
> > - .add_host = sdhci_pci_uhs2_add_host,
> > - .remove_host = sdhci_pci_uhs2_remove_host,
> > - .ops = &sdhci_gl9767_ops,
> > + .quirks = SDHCI_QUIRK_NO_ENDATTR_IN_NOPDESC,
> > + .quirks2 = SDHCI_QUIRK2_BROKEN_DDR50,
> > + .probe_slot = gli_probe_slot_gl9767,
> > + .add_host = sdhci_pci_uhs2_add_host,
> > + .remove_host = sdhci_pci_uhs2_remove_host,
> > + .ops = &sdhci_gl9767_ops,
> > #ifdef CONFIG_PM_SLEEP
> > - .resume = sdhci_pci_gli_resume,
> > + .suspend = gl9763e_suspend,
> > + .resume = sdhci_pci_gli_resume,
> > #endif
> > -};
> > +};
> > \ No newline at end of file
There are some code style issues in this diff. Please make sure to
run scripts/checkpatch.pl when preparing future revisions.
Thanks,
Ben Chuang
ps: I've CCed benchuanggli@gmail.com to avoid the corporate
mail disclaimer.
> > --
> > 2.43.0
> >
> >
________________________________
Genesys Logic Email Confidentiality Notice:
This mail and any attachments may contain information that is confidential, proprietary, privileged or otherwise protected by law. The mail is intended solely for the named addressee (or a person responsible for delivering it to the addressee). If you are not the intended recipient of this mail, you are not authorized to read, print, copy or disseminate this mail.
If you have received this email in error, please notify us immediately by reply email and immediately delete this message and any attachments from your system. Please be noted that any unauthorized use, dissemination, distribution or copying of this email is strictly prohibited.
________________________________
Genesys Logic will participate in Computex 2026 (June 2-5, 2026). Visit our booth at N0614 (TaiNEX 1, 4F, USB-IF) & R0902 (TaiNEX 2, 4F, SD Association) in the Taipei Nangang Exhibition Center.
________________________________
^ permalink raw reply [flat|nested] 3+ messages in thread