From: Markus Elfring <Markus.Elfring@web.de>
To: Hongbo Yao <yaohongbo@huawei.com>, linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Chen Zhou <chenzhou10@huawei.com>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] power: reset: ltc2952: remove set variable but unused value
Date: Sat, 9 May 2020 09:02:47 +0200 [thread overview]
Message-ID: <e40a971a-68b8-8d63-41d1-2617763fb042@web.de> (raw)
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]
I suggest to improve also this commit message.
* Can it be helpful to replace the word “Fixes” by the text
“An issue was pointed out by the compiler.”?
* How do you think about to add the wording “Thus delete the mentioned variable.”
to the change description?
* The value of an assigned variable was not reused in this function implementation.
Should this detail be better represented in the final commit subject?
* Would you like to add the tag “Fixes”?
Regards,
Markus
reply other threads:[~2020-05-09 7:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e40a971a-68b8-8d63-41d1-2617763fb042@web.de \
--to=markus.elfring@web.de \
--cc=chenzhou10@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
--cc=yaohongbo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®