* Re: [PATCH] power: reset: ltc2952: remove set variable but unused value
@ 2020-05-09 7:02 Markus Elfring
0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-05-09 7:02 UTC (permalink / raw)
To: Hongbo Yao, linux-pm; +Cc: linux-kernel, Chen Zhou, Sebastian Reichel
> Fixes gcc '-Wunused-but-set-variable' warning:
> drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable
> ‘overruns’ set but not used [-Wunused-but-set-variable]
I suggest to improve also this commit message.
* Can it be helpful to replace the word “Fixes” by the text
“An issue was pointed out by the compiler.”?
* How do you think about to add the wording “Thus delete the mentioned variable.”
to the change description?
* The value of an assigned variable was not reused in this function implementation.
Should this detail be better represented in the final commit subject?
* Would you like to add the tag “Fixes”?
Regards,
Markus
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-05-09 7:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-09 7:02 [PATCH] power: reset: ltc2952: remove set variable but unused value Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®