mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] sh: hd64461: Make setup_hd64461 static
@ 2024-02-11 19:34 Artur Rojek
  2024-02-14 12:56 ` John Paul Adrian Glaubitz
  0 siblings, 1 reply; 2+ messages in thread
From: Artur Rojek @ 2024-02-11 19:34 UTC (permalink / raw)
  To: Yoshinori Sato, Rich Felker, John Paul Adrian Glaubitz
  Cc: linux-sh, linux-kernel, Artur Rojek

Enforce internal linkage for setup_hd64461.

This fixes the following error:
arch/sh/cchips/hd6446x/hd64461.c:75:12: error: no previous prototype for 'setup_hd64461' [-Werror=missing-prototypes]

Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
---
 arch/sh/cchips/hd6446x/hd64461.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/cchips/hd6446x/hd64461.c b/arch/sh/cchips/hd6446x/hd64461.c
index f3fba967445a..81764882d87d 100644
--- a/arch/sh/cchips/hd6446x/hd64461.c
+++ b/arch/sh/cchips/hd6446x/hd64461.c
@@ -72,7 +72,7 @@ static void hd64461_irq_demux(struct irq_desc *desc)
 	}
 }
 
-int __init setup_hd64461(void)
+static int __init setup_hd64461(void)
 {
 	int irq_base, i;
 
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sh: hd64461: Make setup_hd64461 static
  2024-02-11 19:34 [PATCH] sh: hd64461: Make setup_hd64461 static Artur Rojek
@ 2024-02-14 12:56 ` John Paul Adrian Glaubitz
  0 siblings, 0 replies; 2+ messages in thread
From: John Paul Adrian Glaubitz @ 2024-02-14 12:56 UTC (permalink / raw)
  To: Artur Rojek, Yoshinori Sato, Rich Felker; +Cc: linux-sh, linux-kernel

On Sun, 2024-02-11 at 20:34 +0100, Artur Rojek wrote:
> Enforce internal linkage for setup_hd64461.
> 
> This fixes the following error:
> arch/sh/cchips/hd6446x/hd64461.c:75:12: error: no previous prototype for 'setup_hd64461' [-Werror=missing-prototypes]
> 
> Signed-off-by: Artur Rojek <contact@artur-rojek.eu>
> ---
>  arch/sh/cchips/hd6446x/hd64461.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/cchips/hd6446x/hd64461.c b/arch/sh/cchips/hd6446x/hd64461.c
> index f3fba967445a..81764882d87d 100644
> --- a/arch/sh/cchips/hd6446x/hd64461.c
> +++ b/arch/sh/cchips/hd6446x/hd64461.c
> @@ -72,7 +72,7 @@ static void hd64461_irq_demux(struct irq_desc *desc)
>  	}
>  }
>  
> -int __init setup_hd64461(void)
> +static int __init setup_hd64461(void)
>  {
>  	int irq_base, i;
>  

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

I will merge this patch for 6.9 tonight.

Thanks,
Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-14 12:56 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-11 19:34 [PATCH] sh: hd64461: Make setup_hd64461 static Artur Rojek
2024-02-14 12:56 ` John Paul Adrian Glaubitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®