Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash driver

[Fenglin Wu <quic_fenglinw@quicinc.com>]

On 7/18/2023 5:32 PM, Krzysztof Kozlowski wrote:
> On 18/07/2023 11:24, Fenglin Wu wrote:
>> Update the driver to address following minor issues:
>>   - Add a sentence in Kconfig to explain the driver can be compiled
>>     as a module
>>   - strobe off the LED channel before setting flash current to prevent
>>     the flash LED being lit with an incorrect brightness if it was
>>     already active in torch mode
>>   - put the child node if register any flash LED device failed.
> 
> Don't mix different fixes and changes in one commit.
> 
> Also, please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC (and consider --no-git-fallback argument). I
> really do not see a point why I am cc-ed here.
> 
> Best regards,
> Krzysztof

I understood that we should separate the changes for different fixes.

I am trying to address the review comment from Pavel that was coming 
late after the original changes were applied: 
https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/ (sorry 
for just got time to work on this), since all of them are small ones and 
all related with the same driver, so I thought it might be good to put 
them together and update with a single patch?

BTW, you are copied because you also reviewed the original changes.
Thanks



>