From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Fenglin Wu <quic_fenglinw@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
lee@kernel.org, pavel@ucw.cz, ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Dylan Van Assche <me@dylanvanassche.be>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Tom Rix <trix@redhat.com>,
linux-leds@vger.kernel.org
Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com
Subject: Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash driver
Date: Tue, 18 Jul 2023 11:32:51 +0200 [thread overview]
Message-ID: <d246292b-c0df-fa70-7561-9523e4db6138@linaro.org> (raw)
In-Reply-To: <20230718092439.2482320-1-quic_fenglinw@quicinc.com>
On 18/07/2023 11:24, Fenglin Wu wrote:
> Update the driver to address following minor issues:
> - Add a sentence in Kconfig to explain the driver can be compiled
> as a module
> - strobe off the LED channel before setting flash current to prevent
> the flash LED being lit with an incorrect brightness if it was
> already active in torch mode
> - put the child node if register any flash LED device failed.
Don't mix different fixes and changes in one commit.
Also, please use scripts/get_maintainers.pl to get a list of necessary
people and lists to CC (and consider --no-git-fallback argument). I
really do not see a point why I am cc-ed here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-18 9:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 9:24 Fenglin Wu
2023-07-18 9:32 ` Krzysztof Kozlowski [this message]
2023-07-18 9:52 ` Fenglin Wu
2023-07-19 8:50 ` Lee Jones
2023-07-19 8:52 ` Fenglin Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d246292b-c0df-fa70-7561-9523e4db6138@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alice_chen@richtek.com \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=pavel@ucw.cz \
--cc=quic_collinsd@quicinc.com \
--cc=quic_fenglinw@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®