* [PATCH 0/3] Enable Multi Core Timer (MCT) for gs101
@ 2023-12-22 16:53 Peter Griffin
2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin
` (2 more replies)
0 siblings, 3 replies; 18+ messages in thread
From: Peter Griffin @ 2023-12-22 16:53 UTC (permalink / raw)
To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt,
alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette,
sboyd
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk,
linux-kernel, kernel-team, peter.griffin, tudor.ambarus,
andre.draszik, semen.protsenko, saravanak, willmcvicker
Hi folks,
This series enables Multi Core Timer (MCT) for gs101. As part of enabling
MCT we also need to register cmu_misc bank of clocks early so exynos_mct can
obtain it's clock.
MCT timer is required longer term as the Arm arch timer can't wake the CPU from
suspend. This series is based off todays linux-next.
Note the dtsi change without the corresponding clock driver changes will result
in a system that doesn't boot. So ideally this would both be merged together
through Krzysztofs Samsung exynos tree. If that is OK with everyone?
regards,
Peter
Peter Griffin (3):
dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible
clk: samsung: gs101: register cmu_misc clocks early
arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node
.../timer/samsung,exynos4210-mct.yaml | 2 ++
arch/arm64/boot/dts/exynos/google/gs101.dtsi | 20 +++++++++++++++++++
drivers/clk/samsung/clk-gs101.c | 12 ++++++++---
3 files changed, 31 insertions(+), 3 deletions(-)
--
2.43.0.472.g3155946c3a-goog
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 [PATCH 0/3] Enable Multi Core Timer (MCT) for gs101 Peter Griffin @ 2023-12-22 16:53 ` Peter Griffin 2023-12-22 16:58 ` Sam Protsenko ` (4 more replies) 2023-12-22 16:53 ` [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early Peter Griffin 2023-12-22 16:53 ` [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node Peter Griffin 2 siblings, 5 replies; 18+ messages in thread From: Peter Griffin @ 2023-12-22 16:53 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, peter.griffin, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker Add dedicated google,gs101-mct compatible to the dt-schema for representing mct timer of the Google Tensor gs101 SoC. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml index 829bd2227f7c..774b7992a0ca 100644 --- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml +++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml @@ -26,6 +26,7 @@ properties: - items: - enum: - axis,artpec8-mct + - google,gs101-mct - samsung,exynos3250-mct - samsung,exynos5250-mct - samsung,exynos5260-mct @@ -127,6 +128,7 @@ allOf: contains: enum: - axis,artpec8-mct + - google,gs101-mct - samsung,exynos5260-mct - samsung,exynos5420-mct - samsung,exynos5433-mct -- 2.43.0.472.g3155946c3a-goog ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin @ 2023-12-22 16:58 ` Sam Protsenko 2023-12-23 14:14 ` Krzysztof Kozlowski ` (3 subsequent siblings) 4 siblings, 0 replies; 18+ messages in thread From: Sam Protsenko @ 2023-12-22 16:58 UTC (permalink / raw) To: Peter Griffin Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, saravanak, willmcvicker On Fri, Dec 22, 2023 at 10:54 AM Peter Griffin <peter.griffin@linaro.org> wrote: > > Add dedicated google,gs101-mct compatible to the dt-schema for > representing mct timer of the Google Tensor gs101 SoC. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml > index 829bd2227f7c..774b7992a0ca 100644 > --- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml > +++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml > @@ -26,6 +26,7 @@ properties: > - items: > - enum: > - axis,artpec8-mct > + - google,gs101-mct > - samsung,exynos3250-mct > - samsung,exynos5250-mct > - samsung,exynos5260-mct > @@ -127,6 +128,7 @@ allOf: > contains: > enum: > - axis,artpec8-mct > + - google,gs101-mct > - samsung,exynos5260-mct > - samsung,exynos5420-mct > - samsung,exynos5433-mct > -- > 2.43.0.472.g3155946c3a-goog > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin 2023-12-22 16:58 ` Sam Protsenko @ 2023-12-23 14:14 ` Krzysztof Kozlowski 2024-01-22 11:00 ` Krzysztof Kozlowski ` (2 subsequent siblings) 4 siblings, 0 replies; 18+ messages in thread From: Krzysztof Kozlowski @ 2023-12-23 14:14 UTC (permalink / raw) To: Peter Griffin, robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 22/12/2023 17:53, Peter Griffin wrote: > Add dedicated google,gs101-mct compatible to the dt-schema for > representing mct timer of the Google Tensor gs101 SoC. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I assume this will go via clocksource/timer. But I am also fine taking it via Samsung SoC tree if needed. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin 2023-12-22 16:58 ` Sam Protsenko 2023-12-23 14:14 ` Krzysztof Kozlowski @ 2024-01-22 11:00 ` Krzysztof Kozlowski 2024-01-22 11:19 ` Peter Griffin 2024-01-22 12:11 ` Daniel Lezcano 2024-03-18 10:07 ` [tip: timers/core] " tip-bot2 for Peter Griffin 4 siblings, 1 reply; 18+ messages in thread From: Krzysztof Kozlowski @ 2024-01-22 11:00 UTC (permalink / raw) To: Peter Griffin, robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 22/12/2023 17:53, Peter Griffin wrote: > Add dedicated google,gs101-mct compatible to the dt-schema for > representing mct timer of the Google Tensor gs101 SoC. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ > 1 file changed, 2 insertions(+) > I applied remaining two patches. Let me know if I should grab this. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2024-01-22 11:00 ` Krzysztof Kozlowski @ 2024-01-22 11:19 ` Peter Griffin 2024-01-22 11:21 ` Krzysztof Kozlowski 0 siblings, 1 reply; 18+ messages in thread From: Peter Griffin @ 2024-01-22 11:19 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker Hi Krzysztof, On Mon, 22 Jan 2024 at 11:00, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 22/12/2023 17:53, Peter Griffin wrote: > > Add dedicated google,gs101-mct compatible to the dt-schema for > > representing mct timer of the Google Tensor gs101 SoC. > > > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > I applied remaining two patches. Let me know if I should grab this. If you have applied clk: samsung: gs101: register cmu_misc clocks early arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node then if you can also take this one that would be great. kind regards, Peter ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2024-01-22 11:19 ` Peter Griffin @ 2024-01-22 11:21 ` Krzysztof Kozlowski 2024-01-22 11:35 ` Peter Griffin 0 siblings, 1 reply; 18+ messages in thread From: Krzysztof Kozlowski @ 2024-01-22 11:21 UTC (permalink / raw) To: Peter Griffin Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 22/01/2024 12:19, Peter Griffin wrote: > Hi Krzysztof, > > On Mon, 22 Jan 2024 at 11:00, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 22/12/2023 17:53, Peter Griffin wrote: >>> Add dedicated google,gs101-mct compatible to the dt-schema for >>> representing mct timer of the Google Tensor gs101 SoC. >>> >>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org> >>> --- >>> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >> >> I applied remaining two patches. Let me know if I should grab this. > > If you have applied > clk: samsung: gs101: register cmu_misc clocks early > arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node > > then if you can also take this one that would be great. I know that you want it, but what I meant: If Daniel acks it or if Daniel does not take it in some reasonable time, ping me. Reasonable time starts from rc1 :) Best regards, Krzysztof ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2024-01-22 11:21 ` Krzysztof Kozlowski @ 2024-01-22 11:35 ` Peter Griffin 0 siblings, 0 replies; 18+ messages in thread From: Peter Griffin @ 2024-01-22 11:35 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker Hi Krzysztof, On Mon, 22 Jan 2024 at 11:21, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 22/01/2024 12:19, Peter Griffin wrote: > > Hi Krzysztof, > > > > On Mon, 22 Jan 2024 at 11:00, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 22/12/2023 17:53, Peter Griffin wrote: > >>> Add dedicated google,gs101-mct compatible to the dt-schema for > >>> representing mct timer of the Google Tensor gs101 SoC. > >>> > >>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > >>> --- > >>> .../devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ > >>> 1 file changed, 2 insertions(+) > >>> > >> > >> I applied remaining two patches. Let me know if I should grab this. > > > > If you have applied > > clk: samsung: gs101: register cmu_misc clocks early > > arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node > > > > then if you can also take this one that would be great. > > I know that you want it, but what I meant: > If Daniel acks it or if Daniel does not take it in some reasonable time, > ping me. Reasonable time starts from rc1 :) Right I see, thanks :) Peter. ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin ` (2 preceding siblings ...) 2024-01-22 11:00 ` Krzysztof Kozlowski @ 2024-01-22 12:11 ` Daniel Lezcano 2024-01-30 7:33 ` Krzysztof Kozlowski 2024-03-18 10:07 ` [tip: timers/core] " tip-bot2 for Peter Griffin 4 siblings, 1 reply; 18+ messages in thread From: Daniel Lezcano @ 2024-01-22 12:11 UTC (permalink / raw) To: Peter Griffin, robh+dt, krzysztof.kozlowski+dt, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 22/12/2023 17:53, Peter Griffin wrote: > Add dedicated google,gs101-mct compatible to the dt-schema for > representing mct timer of the Google Tensor gs101 SoC. > Applied, thanks -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2024-01-22 12:11 ` Daniel Lezcano @ 2024-01-30 7:33 ` Krzysztof Kozlowski 2024-01-30 9:55 ` Daniel Lezcano 0 siblings, 1 reply; 18+ messages in thread From: Krzysztof Kozlowski @ 2024-01-30 7:33 UTC (permalink / raw) To: Daniel Lezcano, Peter Griffin, robh+dt, krzysztof.kozlowski+dt, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 22/01/2024 13:11, Daniel Lezcano wrote: > On 22/12/2023 17:53, Peter Griffin wrote: >> Add dedicated google,gs101-mct compatible to the dt-schema for >> representing mct timer of the Google Tensor gs101 SoC. >> > > Applied, thanks Daniel, You a week ago that this was applied, but I still do not see the patch in linux-next. Can you double check? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2024-01-30 7:33 ` Krzysztof Kozlowski @ 2024-01-30 9:55 ` Daniel Lezcano 0 siblings, 0 replies; 18+ messages in thread From: Daniel Lezcano @ 2024-01-30 9:55 UTC (permalink / raw) To: Krzysztof Kozlowski, Peter Griffin, robh+dt, krzysztof.kozlowski+dt, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On 30/01/2024 08:33, Krzysztof Kozlowski wrote: > On 22/01/2024 13:11, Daniel Lezcano wrote: >> On 22/12/2023 17:53, Peter Griffin wrote: >>> Add dedicated google,gs101-mct compatible to the dt-schema for >>> representing mct timer of the Google Tensor gs101 SoC. >>> >> >> Applied, thanks > > Daniel, > You a week ago that this was applied, but I still do not see the patch > in linux-next. Can you double check? It is applied, but I did not pushed the branch. It is done now, it should appear in linux-next soon. Thanks for the head up -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 18+ messages in thread
* [tip: timers/core] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin ` (3 preceding siblings ...) 2024-01-22 12:11 ` Daniel Lezcano @ 2024-03-18 10:07 ` tip-bot2 for Peter Griffin 4 siblings, 0 replies; 18+ messages in thread From: tip-bot2 for Peter Griffin @ 2024-03-18 10:07 UTC (permalink / raw) To: linux-tip-commits Cc: Peter Griffin, Krzysztof Kozlowski, Sam Protsenko, Daniel Lezcano, x86, linux-kernel The following commit has been merged into the timers/core branch of tip: Commit-ID: f253c9a1aa3360bd6d61407dbfc6ca002855caa3 Gitweb: https://git.kernel.org/tip/f253c9a1aa3360bd6d61407dbfc6ca002855caa3 Author: Peter Griffin <peter.griffin@linaro.org> AuthorDate: Fri, 22 Dec 2023 16:53:53 Committer: Daniel Lezcano <daniel.lezcano@linaro.org> CommitterDate: Mon, 22 Jan 2024 13:11:27 +01:00 dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Add dedicated google,gs101-mct compatible to the dt-schema for representing mct timer of the Google Tensor gs101 SoC. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20231222165355.1462740-2-peter.griffin@linaro.org --- Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml index 829bd22..774b799 100644 --- a/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml +++ b/Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.yaml @@ -26,6 +26,7 @@ properties: - items: - enum: - axis,artpec8-mct + - google,gs101-mct - samsung,exynos3250-mct - samsung,exynos5250-mct - samsung,exynos5260-mct @@ -127,6 +128,7 @@ allOf: contains: enum: - axis,artpec8-mct + - google,gs101-mct - samsung,exynos5260-mct - samsung,exynos5420-mct - samsung,exynos5433-mct ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early 2023-12-22 16:53 [PATCH 0/3] Enable Multi Core Timer (MCT) for gs101 Peter Griffin 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin @ 2023-12-22 16:53 ` Peter Griffin 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski 2023-12-22 16:53 ` [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node Peter Griffin 2 siblings, 2 replies; 18+ messages in thread From: Peter Griffin @ 2023-12-22 16:53 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, peter.griffin, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker Update cmu_misc so it is registered early, as it contains the gate which clocks the Multi Core Timer (MCT). This clock is required early in boot, otherwise exynos_mct will fail obtaining the clock. Note this wasn't previously an issue as exynos_mct wasn't enabled. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- drivers/clk/samsung/clk-gs101.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c index 0964bb11657f..590119a25c18 100644 --- a/drivers/clk/samsung/clk-gs101.c +++ b/drivers/clk/samsung/clk-gs101.c @@ -2478,6 +2478,15 @@ static const struct samsung_cmu_info misc_cmu_info __initconst = { .clk_name = "dout_cmu_misc_bus", }; +static void __init gs101_cmu_misc_init(struct device_node *np) +{ + exynos_arm64_register_cmu(NULL, np, &misc_cmu_info); +} + +/* Register CMU_MISC early, as it's needed for MCT timer */ +CLK_OF_DECLARE(gs101_cmu_misc, "google,gs101-cmu-misc", + gs101_cmu_misc_init); + /* ---- platform_driver ----------------------------------------------------- */ static int __init gs101_cmu_probe(struct platform_device *pdev) @@ -2495,9 +2504,6 @@ static const struct of_device_id gs101_cmu_of_match[] = { { .compatible = "google,gs101-cmu-apm", .data = &apm_cmu_info, - }, { - .compatible = "google,gs101-cmu-misc", - .data = &misc_cmu_info, }, { }, }; -- 2.43.0.472.g3155946c3a-goog ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early 2023-12-22 16:53 ` [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early Peter Griffin @ 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski 1 sibling, 0 replies; 18+ messages in thread From: Sam Protsenko @ 2023-12-22 16:59 UTC (permalink / raw) To: Peter Griffin Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, saravanak, willmcvicker On Fri, Dec 22, 2023 at 10:54 AM Peter Griffin <peter.griffin@linaro.org> wrote: > > Update cmu_misc so it is registered early, as it contains > the gate which clocks the Multi Core Timer (MCT). This clock > is required early in boot, otherwise exynos_mct will fail > obtaining the clock. > > Note this wasn't previously an issue as exynos_mct wasn't > enabled. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/clk/samsung/clk-gs101.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/clk/samsung/clk-gs101.c b/drivers/clk/samsung/clk-gs101.c > index 0964bb11657f..590119a25c18 100644 > --- a/drivers/clk/samsung/clk-gs101.c > +++ b/drivers/clk/samsung/clk-gs101.c > @@ -2478,6 +2478,15 @@ static const struct samsung_cmu_info misc_cmu_info __initconst = { > .clk_name = "dout_cmu_misc_bus", > }; > > +static void __init gs101_cmu_misc_init(struct device_node *np) > +{ > + exynos_arm64_register_cmu(NULL, np, &misc_cmu_info); > +} > + > +/* Register CMU_MISC early, as it's needed for MCT timer */ > +CLK_OF_DECLARE(gs101_cmu_misc, "google,gs101-cmu-misc", > + gs101_cmu_misc_init); > + > /* ---- platform_driver ----------------------------------------------------- */ > > static int __init gs101_cmu_probe(struct platform_device *pdev) > @@ -2495,9 +2504,6 @@ static const struct of_device_id gs101_cmu_of_match[] = { > { > .compatible = "google,gs101-cmu-apm", > .data = &apm_cmu_info, > - }, { > - .compatible = "google,gs101-cmu-misc", > - .data = &misc_cmu_info, > }, { > }, > }; > -- > 2.43.0.472.g3155946c3a-goog > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early 2023-12-22 16:53 ` [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early Peter Griffin 2023-12-22 16:59 ` Sam Protsenko @ 2024-01-22 11:15 ` Krzysztof Kozlowski 1 sibling, 0 replies; 18+ messages in thread From: Krzysztof Kozlowski @ 2024-01-22 11:15 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, Peter Griffin Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On Fri, 22 Dec 2023 16:53:54 +0000, Peter Griffin wrote: > Update cmu_misc so it is registered early, as it contains > the gate which clocks the Multi Core Timer (MCT). This clock > is required early in boot, otherwise exynos_mct will fail > obtaining the clock. > > Note this wasn't previously an issue as exynos_mct wasn't > enabled. > > [...] Applied, thanks! [2/3] clk: samsung: gs101: register cmu_misc clocks early https://git.kernel.org/krzk/linux/c/163cd42fc49081964e0fc6f0b1e94b6b50eb85f5 Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node 2023-12-22 16:53 [PATCH 0/3] Enable Multi Core Timer (MCT) for gs101 Peter Griffin 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin 2023-12-22 16:53 ` [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early Peter Griffin @ 2023-12-22 16:53 ` Peter Griffin 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski 2 siblings, 2 replies; 18+ messages in thread From: Peter Griffin @ 2023-12-22 16:53 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, peter.griffin, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker MCT has one global timer and 8 CPU local timers. The global timer can generate 4 interrupts, and each local timer can generate an interrupt making 12 interrupts in total. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- arch/arm64/boot/dts/exynos/google/gs101.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi index 9747cb3fa03a..4b09e740b58a 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi @@ -292,6 +292,26 @@ cmu_misc: clock-controller@10010000 { clock-names = "dout_cmu_misc_bus", "dout_cmu_misc_sss"; }; + timer@10050000 { + compatible = "google,gs101-mct", + "samsung,exynos4210-mct"; + reg = <0x10050000 0x800>; + interrupts = <GIC_SPI 753 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 754 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 755 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 756 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 757 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 763 IRQ_TYPE_LEVEL_HIGH 0>, + <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&ext_24_5m>, <&cmu_misc CLK_GOUT_MISC_MCT_PCLK>; + clock-names = "fin_pll", "mct"; + }; + watchdog_cl0: watchdog@10060000 { compatible = "google,gs101-wdt"; reg = <0x10060000 0x100>; -- 2.43.0.472.g3155946c3a-goog ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node 2023-12-22 16:53 ` [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node Peter Griffin @ 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski 1 sibling, 0 replies; 18+ messages in thread From: Sam Protsenko @ 2023-12-22 16:59 UTC (permalink / raw) To: Peter Griffin Cc: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, saravanak, willmcvicker On Fri, Dec 22, 2023 at 10:54 AM Peter Griffin <peter.griffin@linaro.org> wrote: > > MCT has one global timer and 8 CPU local timers. The global timer > can generate 4 interrupts, and each local timer can generate an > interrupt making 12 interrupts in total. > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index 9747cb3fa03a..4b09e740b58a 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -292,6 +292,26 @@ cmu_misc: clock-controller@10010000 { > clock-names = "dout_cmu_misc_bus", "dout_cmu_misc_sss"; > }; > > + timer@10050000 { > + compatible = "google,gs101-mct", > + "samsung,exynos4210-mct"; > + reg = <0x10050000 0x800>; > + interrupts = <GIC_SPI 753 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 754 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 755 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 756 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 757 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 758 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 759 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 760 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 761 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 762 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 763 IRQ_TYPE_LEVEL_HIGH 0>, > + <GIC_SPI 764 IRQ_TYPE_LEVEL_HIGH 0>; > + clocks = <&ext_24_5m>, <&cmu_misc CLK_GOUT_MISC_MCT_PCLK>; > + clock-names = "fin_pll", "mct"; > + }; > + > watchdog_cl0: watchdog@10060000 { > compatible = "google,gs101-wdt"; > reg = <0x10060000 0x100>; > -- > 2.43.0.472.g3155946c3a-goog > ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: (subset) [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node 2023-12-22 16:53 ` [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node Peter Griffin 2023-12-22 16:59 ` Sam Protsenko @ 2024-01-22 11:15 ` Krzysztof Kozlowski 1 sibling, 0 replies; 18+ messages in thread From: Krzysztof Kozlowski @ 2024-01-22 11:15 UTC (permalink / raw) To: robh+dt, krzysztof.kozlowski+dt, daniel.lezcano, tglx, conor+dt, alim.akhtar, s.nawrocki, tomasz.figa, cw00.choi, mturquette, sboyd, Peter Griffin Cc: devicetree, linux-arm-kernel, linux-samsung-soc, linux-clk, linux-kernel, kernel-team, tudor.ambarus, andre.draszik, semen.protsenko, saravanak, willmcvicker On Fri, 22 Dec 2023 16:53:55 +0000, Peter Griffin wrote: > MCT has one global timer and 8 CPU local timers. The global timer > can generate 4 interrupts, and each local timer can generate an > interrupt making 12 interrupts in total. > > Applied, thanks! [3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node https://git.kernel.org/krzk/linux/c/2b1b22054a8240e8e806d872b6fc361611f9c7a2 Best regards, -- Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-03-18 10:07 UTC | newest] Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2023-12-22 16:53 [PATCH 0/3] Enable Multi Core Timer (MCT) for gs101 Peter Griffin 2023-12-22 16:53 ` [PATCH 1/3] dt-bindings: timer: exynos4210-mct: Add google,gs101-mct compatible Peter Griffin 2023-12-22 16:58 ` Sam Protsenko 2023-12-23 14:14 ` Krzysztof Kozlowski 2024-01-22 11:00 ` Krzysztof Kozlowski 2024-01-22 11:19 ` Peter Griffin 2024-01-22 11:21 ` Krzysztof Kozlowski 2024-01-22 11:35 ` Peter Griffin 2024-01-22 12:11 ` Daniel Lezcano 2024-01-30 7:33 ` Krzysztof Kozlowski 2024-01-30 9:55 ` Daniel Lezcano 2024-03-18 10:07 ` [tip: timers/core] " tip-bot2 for Peter Griffin 2023-12-22 16:53 ` [PATCH 2/3] clk: samsung: gs101: register cmu_misc clocks early Peter Griffin 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski 2023-12-22 16:53 ` [PATCH 3/3] arm64: dts: exynos: gs101: define Multi Core Timer (MCT) node Peter Griffin 2023-12-22 16:59 ` Sam Protsenko 2024-01-22 11:15 ` (subset) " Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®