From: Babu Moger <babu.moger@amd.com>
To: <tony.luck@intel.com>, <reinette.chatre@intel.com>,
<peternewman@google.com>
Cc: <corbet@lwn.net>, <tglx@linutronix.de>, <mingo@redhat.com>,
<bp@alien8.de>, <dave.hansen@linux.intel.com>, <x86@kernel.org>,
<hpa@zytor.com>, <paulmck@kernel.org>,
<akpm@linux-foundation.org>, <thuth@redhat.com>,
<rostedt@goodmis.org>, <ardb@kernel.org>,
<gregkh@linuxfoundation.org>, <daniel.sneddon@linux.intel.com>,
<jpoimboe@kernel.org>, <alexandre.chartre@oracle.com>,
<pawan.kumar.gupta@linux.intel.com>, <thomas.lendacky@amd.com>,
<perry.yuan@amd.com>, <seanjc@google.com>, <kai.huang@intel.com>,
<xiaoyao.li@intel.com>, <babu.moger@amd.com>,
<kan.liang@linux.intel.com>, <xin3.li@intel.com>,
<ebiggers@google.com>, <xin@zytor.com>, <sohil.mehta@intel.com>,
<andrew.cooper3@citrix.com>, <mario.limonciello@amd.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<maciej.wieczor-retman@intel.com>, <eranian@google.com>
Subject: [PATCH v12 23/26] x86/resctrl: Introduce mbm_L3_assignments to list assignments in a group
Date: Thu, 3 Apr 2025 19:18:32 -0500 [thread overview]
Message-ID: <e42cd8c2f6beaeeac4bf2f71e4aac0ce897fbcf8.1743725907.git.babu.moger@amd.com> (raw)
In-Reply-To: <cover.1743725907.git.babu.moger@amd.com>
The interface displays the assignment states for each group when
mbm_cntr_assign mode is enabled.
The list is displayed in the following format:
<Event configuration>:<Domain id>=<Assignment type>
Event configuration: A valid event configuration listed in the
/sys/fs/resctrl/info/L3_MON/counter_configs directory.
Domain ID: A valid domain ID number.
The assignment type can be one of the following:
_ : No event configuration assigned
e : Event configuration assigned in exclusive mode
Example:
$cd /sys/fs/resctrl
$cat mbm_L3_assignments
mbm_total_bytes:0=e;1=e
mbm_local_bytes:0=e;1=e
Signed-off-by: Babu Moger <babu.moger@amd.com>
---
v12: New patch:
Assignment interface moved inside the group based the discussion
https://lore.kernel.org/lkml/CALPaoCiii0vXOF06mfV=kVLBzhfNo0SFqt4kQGwGSGVUqvr2Dg@mail.gmail.com/#t
---
Documentation/arch/x86/resctrl.rst | 27 +++++++++++++++
arch/x86/kernel/cpu/resctrl/monitor.c | 1 +
arch/x86/kernel/cpu/resctrl/rdtgroup.c | 48 ++++++++++++++++++++++++++
3 files changed, 76 insertions(+)
diff --git a/Documentation/arch/x86/resctrl.rst b/Documentation/arch/x86/resctrl.rst
index a67f09323da0..31085b4e15f6 100644
--- a/Documentation/arch/x86/resctrl.rst
+++ b/Documentation/arch/x86/resctrl.rst
@@ -503,6 +503,33 @@ When the "mba_MBps" mount option is used all CTRL_MON groups will also contain:
/sys/fs/resctrl/info/L3_MON/mon_features changes the input
event.
+"mbm_L3_assignments":
+ The interface displays the assignment states for each group when
+ mbm_cntr_assign mode is enabled.
+
+ The list is displayed in the following format:
+
+ <Event configuration>:<Domain id>=<Assignment type>
+
+ Event configuration: A valid event configuration listed in the
+ /sys/fs/resctrl/info/L3_MON/counter_configs directory.
+
+ Domain ID: A valid domain ID number.
+
+ Assignment types:
+
+ _ : No event configuration assigned
+
+ e : Event configuration assigned in exclusive mode
+
+ Example:
+ ::
+
+ # cd /sys/fs/resctrl
+ # cat mbm_L3_assignments
+ mbm_total_bytes:0=e;1=e
+ mbm_local_bytes:0=e;1=e
+
Resource allocation rules
-------------------------
diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c
index 4e22563dda60..0c6fd5f6ec19 100644
--- a/arch/x86/kernel/cpu/resctrl/monitor.c
+++ b/arch/x86/kernel/cpu/resctrl/monitor.c
@@ -1266,6 +1266,7 @@ int __init resctrl_mon_resource_init(void)
resctrl_file_fflags_init("available_mbm_cntrs", RFTYPE_MON_INFO);
resctrl_file_fflags_init("event_filter", RFTYPE_MON_CONFIG);
resctrl_file_fflags_init("mbm_assign_on_mkdir", RFTYPE_MON_INFO);
+ resctrl_file_fflags_init("mbm_L3_assignments", RFTYPE_MON_BASE);
}
return 0;
diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
index 3e440ace60e0..ee1c949c2436 100644
--- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c
+++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c
@@ -2083,6 +2083,48 @@ static ssize_t event_filter_write(struct kernfs_open_file *of, char *buf,
return ret ?: nbytes;
}
+static int mbm_L3_assignments_show(struct kernfs_open_file *of, struct seq_file *s, void *v)
+{
+ struct rdt_resource *r = resctrl_arch_get_resource(RDT_RESOURCE_L3);
+ struct rdt_mon_domain *d;
+ struct rdtgroup *rdtgrp;
+ int i, ret = 0;
+ bool sep;
+
+ rdtgrp = rdtgroup_kn_lock_live(of->kn);
+ if (!rdtgrp)
+ return -ENOENT;
+
+ rdt_last_cmd_clear();
+ if (!resctrl_arch_mbm_cntr_assign_enabled(r)) {
+ rdt_last_cmd_puts("mbm_cntr_assign mode not enabled\n");
+ ret = -ENOENT;
+ goto assign_out;
+ }
+
+ for (i = 0; i < NUM_MBM_ASSIGN_CONFIGS; i++) {
+ sep = false;
+ seq_printf(s, "%s:", mbm_assign_configs[i].name);
+ list_for_each_entry(d, &r->mon_domains, hdr.list) {
+ if (sep)
+ seq_puts(s, ";");
+
+ if (mbm_cntr_get(r, d, rdtgrp, mbm_assign_configs[i].evtid) >= 0)
+ seq_printf(s, "%d=e", d->hdr.id);
+ else
+ seq_printf(s, "%d=_", d->hdr.id);
+
+ sep = true;
+ }
+ seq_puts(s, "\n");
+ }
+
+assign_out:
+ rdtgroup_kn_unlock(of->kn);
+
+ return ret;
+}
+
/* rdtgroup information files for one cache resource. */
static struct rftype res_common_files[] = {
{
@@ -2202,6 +2244,12 @@ static struct rftype res_common_files[] = {
.seq_show = event_filter_show,
.write = event_filter_write,
},
+ {
+ .name = "mbm_L3_assignments",
+ .mode = 0444,
+ .kf_ops = &rdtgroup_kf_single_ops,
+ .seq_show = mbm_L3_assignments_show,
+ },
{
.name = "mbm_assign_mode",
.mode = 0444,
--
2.34.1
next prev parent reply other threads:[~2025-04-04 0:22 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 0:18 [PATCH v12 00/26] x86/resctrl : Support AMD Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2025-04-04 0:18 ` [PATCH v12 01/26] x86/resctrl: Introduce mbm_total_cfg and mbm_local_cfg in struct rdt_hw_mon_domain Babu Moger
2025-04-11 20:49 ` Reinette Chatre
2025-04-14 15:56 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 02/26] x86/resctrl: Remove MSR reading of event configuration value Babu Moger
2025-04-11 20:50 ` Reinette Chatre
2025-04-14 15:57 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 03/26] x86/cpufeatures: Add support for Assignable Bandwidth Monitoring Counters (ABMC) Babu Moger
2025-04-11 20:52 ` Reinette Chatre
2025-04-14 17:48 ` Moger, Babu
2025-04-15 16:09 ` Reinette Chatre
2025-04-15 19:43 ` Moger, Babu
2025-04-16 16:08 ` Reinette Chatre
2025-04-17 14:27 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 04/26] x86/resctrl: Add ABMC feature in the command line options Babu Moger
2025-04-04 0:18 ` [PATCH v12 05/26] x86/resctrl: Consolidate monitoring related data from rdt_resource Babu Moger
2025-04-04 0:18 ` [PATCH v12 06/26] x86/resctrl: Detect Assignable Bandwidth Monitoring feature details Babu Moger
2025-04-04 0:18 ` [PATCH v12 07/26] x86/resctrl: Add support to enable/disable AMD ABMC feature Babu Moger
2025-04-04 0:18 ` [PATCH v12 08/26] x86/resctrl: Introduce the interface to display monitor mode Babu Moger
2025-04-11 20:56 ` Reinette Chatre
2025-04-14 19:52 ` Moger, Babu
2025-04-15 16:22 ` Reinette Chatre
2025-04-16 14:05 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 09/26] x86/resctrl: Introduce interface to display number of monitoring counters Babu Moger
2025-04-11 21:01 ` Reinette Chatre
2025-04-14 20:12 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 10/26] x86/resctrl: Introduce mbm_cntr_cfg to track assignable counters at domain Babu Moger
2025-04-04 0:18 ` [PATCH v12 11/26] x86/resctrl: Introduce interface to display number of free MBM counters Babu Moger
2025-04-04 0:18 ` [PATCH v12 12/26] x86/resctrl: Add data structures and definitions for ABMC assignment Babu Moger
2025-04-11 21:01 ` Reinette Chatre
2025-04-14 20:30 ` Moger, Babu
2025-04-15 16:30 ` Reinette Chatre
2025-04-16 15:43 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 13/26] x86/resctrl: Implement resctrl_arch_config_cntr() to assign a counter with ABMC Babu Moger
2025-04-11 21:02 ` Reinette Chatre
2025-04-14 20:51 ` Moger, Babu
2025-04-15 16:38 ` Reinette Chatre
2025-04-16 15:51 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 14/26] x86/resctrl: Add the functionality to assign MBM events Babu Moger
2025-04-11 21:04 ` Reinette Chatre
2025-04-15 14:20 ` Moger, Babu
2025-04-15 16:53 ` Reinette Chatre
2025-04-16 17:09 ` Moger, Babu
2025-04-16 17:55 ` Luck, Tony
2025-04-16 18:17 ` Moger, Babu
2025-04-16 19:02 ` Reinette Chatre
2025-04-16 19:29 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 15/26] x86/resctrl: Add the functionality to unassign " Babu Moger
2025-04-04 0:18 ` [PATCH v12 16/26] x86/resctrl: Report 'Unassigned' for MBM events in mbm_cntr_assign mode Babu Moger
2025-04-11 21:08 ` Reinette Chatre
2025-04-15 15:00 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 17/26] x86/resctrl: Add the support for reading ABMC counters Babu Moger
2025-04-11 21:21 ` Reinette Chatre
2025-04-15 16:41 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 18/26] x86/resctrl: Add default MBM event configurations for mbm_cntr_assign mode Babu Moger
2025-04-11 21:44 ` Reinette Chatre
2025-04-15 18:48 ` Moger, Babu
2025-04-15 19:25 ` Luck, Tony
2025-04-16 16:21 ` Reinette Chatre
2025-04-16 17:26 ` Moger, Babu
2025-04-16 16:18 ` Reinette Chatre
2025-04-16 17:27 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 19/26] x86/resctrl: Add event configuration directory under info/L3_MON/ Babu Moger
2025-04-11 22:04 ` Reinette Chatre
2025-04-15 20:29 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 20/26] x86/resctrl: Provide interface to update the event configurations Babu Moger
2025-04-11 22:07 ` Reinette Chatre
2025-04-15 20:37 ` Moger, Babu
2025-04-16 18:52 ` Reinette Chatre
2025-04-17 14:34 ` Moger, Babu
2025-04-17 15:09 ` Reinette Chatre
2025-04-17 20:19 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 21/26] x86/resctrl: Introduce mbm_assign_on_mkdir to configure assignments Babu Moger
2025-04-11 22:08 ` Reinette Chatre
2025-04-15 20:39 ` Moger, Babu
2025-04-04 0:18 ` [PATCH v12 22/26] x86/resctrl: Auto assign/unassign counters when mbm_cntr_assign is enabled Babu Moger
2025-04-04 0:18 ` Babu Moger [this message]
2025-04-04 0:18 ` [PATCH v12 24/26] x86/resctrl: Introduce the interface to modify assignments in a group Babu Moger
2025-04-04 0:18 ` [PATCH v12 25/26] x86/resctrl: Introduce the interface to switch between monitor modes Babu Moger
2025-04-04 0:18 ` [PATCH v12 26/26] x86/resctrl: Configure mbm_cntr_assign mode if supported Babu Moger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e42cd8c2f6beaeeac4bf2f71e4aac0ce897fbcf8.1743725907.git.babu.moger@amd.com \
--to=babu.moger@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alexandre.chartre@oracle.com \
--cc=andrew.cooper3@citrix.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=daniel.sneddon@linux.intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kai.huang@intel.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.wieczor-retman@intel.com \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=perry.yuan@amd.com \
--cc=peternewman@google.com \
--cc=reinette.chatre@intel.com \
--cc=rostedt@goodmis.org \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=thuth@redhat.com \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
--cc=xiaoyao.li@intel.com \
--cc=xin3.li@intel.com \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®