* [PATCH] drm/amd/display: Fix set scaling doesn's work
@ 2022-11-22 11:20 hongao
2023-01-10 15:58 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 4+ messages in thread
From: hongao @ 2022-11-22 11:20 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel,
nicholas.kazlauskas, aurabindo.pillai, roman.li, Jerry.Zuo
Cc: amd-gfx, dri-devel, linux-kernel, hongao
[Why]
Setting scaling does not correctly update CRTC state. As a result
dc stream state's src (composition area) && dest (addressable area)
was not calculated as expected. This causes set scaling doesn's work.
[How]
Correctly update CRTC state when setting scaling property.
Signed-off-by: hongao <hongao@uniontech.com>
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 3e1ecca72430..a88a6f758748 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
goto fail;
}
- if (dm_old_con_state->abm_level !=
- dm_new_con_state->abm_level)
+ if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
+ dm_old_con_state->scaling != dm_new_con_state->scaling)
new_crtc_state->connectors_changed = true;
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: Fix set scaling doesn's work
2022-11-22 11:20 [PATCH] drm/amd/display: Fix set scaling doesn's work hongao
@ 2023-01-10 15:58 ` Rodrigo Siqueira Jordao
2023-01-11 15:19 ` Harry Wentland
0 siblings, 1 reply; 4+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-01-10 15:58 UTC (permalink / raw)
To: harry.wentland, nicholas.kazlauskas, hongao
Cc: amd-gfx, dri-devel, sunpeng.li, linux-kernel, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, aurabindo.pillai,
roman.li, Jerry.Zuo
On 11/22/22 06:20, hongao wrote:
> [Why]
> Setting scaling does not correctly update CRTC state. As a result
> dc stream state's src (composition area) && dest (addressable area)
> was not calculated as expected. This causes set scaling doesn's work.
>
> [How]
> Correctly update CRTC state when setting scaling property.
>
> Signed-off-by: hongao <hongao@uniontech.com>
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 3e1ecca72430..a88a6f758748 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
> goto fail;
> }
>
> - if (dm_old_con_state->abm_level !=
> - dm_new_con_state->abm_level)
> + if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
> + dm_old_con_state->scaling != dm_new_con_state->scaling)
> new_crtc_state->connectors_changed = true;
> }
>
Hi,
This change lgtm, and I also run it in our CI, and from IGT perspective,
we are good.
Harry, do you have any comment about this change?
Thanks
Siqueira
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: Fix set scaling doesn's work
2023-01-10 15:58 ` Rodrigo Siqueira Jordao
@ 2023-01-11 15:19 ` Harry Wentland
2023-01-12 16:08 ` Rodrigo Siqueira Jordao
0 siblings, 1 reply; 4+ messages in thread
From: Harry Wentland @ 2023-01-11 15:19 UTC (permalink / raw)
To: Rodrigo Siqueira Jordao, nicholas.kazlauskas, hongao
Cc: amd-gfx, dri-devel, sunpeng.li, linux-kernel, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, aurabindo.pillai,
roman.li, Jerry.Zuo
On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote:
>
>
> On 11/22/22 06:20, hongao wrote:
>> [Why]
>> Setting scaling does not correctly update CRTC state. As a result
>> dc stream state's src (composition area) && dest (addressable area)
>> was not calculated as expected. This causes set scaling doesn's work.
>>
>> [How]
>> Correctly update CRTC state when setting scaling property.
>>
>> Signed-off-by: hongao <hongao@uniontech.com>
>>
>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> index 3e1ecca72430..a88a6f758748 100644
>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>> @@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
>> goto fail;
>> }
>> - if (dm_old_con_state->abm_level !=
>> - dm_new_con_state->abm_level)
>> + if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
>> + dm_old_con_state->scaling != dm_new_con_state->scaling)
>> new_crtc_state->connectors_changed = true;
>> }
>>
>
> Hi,
>
> This change lgtm, and I also run it in our CI, and from IGT perspective, we are good.
>
> Harry, do you have any comment about this change?
>
LGTM
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> Thanks
> Siqueira
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/display: Fix set scaling doesn's work
2023-01-11 15:19 ` Harry Wentland
@ 2023-01-12 16:08 ` Rodrigo Siqueira Jordao
0 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Siqueira Jordao @ 2023-01-12 16:08 UTC (permalink / raw)
To: Harry Wentland, nicholas.kazlauskas, hongao
Cc: amd-gfx, dri-devel, sunpeng.li, linux-kernel, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, aurabindo.pillai,
roman.li, Jerry.Zuo
On 1/11/23 10:19, Harry Wentland wrote:
> On 1/10/23 10:58, Rodrigo Siqueira Jordao wrote:
>>
>>
>> On 11/22/22 06:20, hongao wrote:
>>> [Why]
>>> Setting scaling does not correctly update CRTC state. As a result
>>> dc stream state's src (composition area) && dest (addressable area)
>>> was not calculated as expected. This causes set scaling doesn's work.
>>>
>>> [How]
>>> Correctly update CRTC state when setting scaling property.
>>>
>>> Signed-off-by: hongao <hongao@uniontech.com>
>>>
>>> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> index 3e1ecca72430..a88a6f758748 100644
>>> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>>> @@ -9386,8 +9386,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
>>> goto fail;
>>> }
>>> - if (dm_old_con_state->abm_level !=
>>> - dm_new_con_state->abm_level)
>>> + if (dm_old_con_state->abm_level != dm_new_con_state->abm_level ||
>>> + dm_old_con_state->scaling != dm_new_con_state->scaling)
>>> new_crtc_state->connectors_changed = true;
>>> }
>>>
>>
>> Hi,
>>
>> This change lgtm, and I also run it in our CI, and from IGT perspective, we are good.
>>
>> Harry, do you have any comment about this change?
>>
>
> LGTM
>
> Reviewed-by: Harry Wentland <harry.wentland@amd.com>
>
> Harry
>
>> Thanks
>> Siqueira
>
Thanks, patch applied to amd-staging-drm-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-01-12 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 11:20 [PATCH] drm/amd/display: Fix set scaling doesn's work hongao
2023-01-10 15:58 ` Rodrigo Siqueira Jordao
2023-01-11 15:19 ` Harry Wentland
2023-01-12 16:08 ` Rodrigo Siqueira Jordao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®