mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
To: Joshua Crofts <crofts@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>,
	David Heidelberg <david@ixit.cz>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	Sylvain Petinot <sylvain.petinot@foss.st.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] media: i2c: vd55g1: remove redundant pm_runtime_dont_use_autosuspend() calls
Date: Tue, 10 Nov 2026 15:20:39 +0100	[thread overview]
Message-ID: <e43e01a5-4121-4ca4-8216-8f20728759d1@foss.st.com> (raw)
In-Reply-To: <20261110-media-remove-dont-use-autosuspend-v1-3-cc07e71b30f9@kernel.org>

Hi Joshua,

Le 10/11/2026 à 15:03, Joshua Crofts a écrit :
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
> 
> Remove the redundant function calls.
> 
> Signed-off-by: Joshua Crofts <crofts@kernel.org>

That's an easy one. Thank you.

Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>

> ---
>  drivers/media/i2c/vd55g1.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 3a3ce32b0610eb23d42b622f2173a505df120176..8ea68dc9b1d99d11a7678138a5b6f7147b595f0a 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -2053,7 +2053,6 @@ static int vd55g1_probe(struct i2c_client *client)
>  err_power_off:
>  	pm_runtime_disable(dev);
>  	pm_runtime_put_noidle(dev);
> -	pm_runtime_dont_use_autosuspend(dev);
>  	vd55g1_power_off(dev);
>  
>  	return ret;
> @@ -2070,7 +2069,6 @@ static void vd55g1_remove(struct i2c_client *client)
>  	if (!pm_runtime_status_suspended(&client->dev))
>  		vd55g1_power_off(&client->dev);
>  	pm_runtime_set_suspended(&client->dev);
> -	pm_runtime_dont_use_autosuspend(&client->dev);
>  }
>  
>  static const struct of_device_id vd55g1_dt_ids[] = {
> 

-- 
Regards,
Benjamin


  reply	other threads:[~2026-11-10 14:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-10 14:03 [PATCH 0/4] media: " Joshua Crofts
2026-11-10 14:03 ` [PATCH 1/4] media: i2c: imx355: " Joshua Crofts
2026-11-10 14:31   ` Dave Stevenson
2026-11-10 14:03 ` [PATCH 2/4] media: i2c: tc358746: " Joshua Crofts
2026-11-10 14:03 ` [PATCH 3/4] media: i2c: vd55g1: " Joshua Crofts
2026-11-10 14:20   ` Benjamin Mugnier [this message]
2026-11-10 14:03 ` [PATCH 4/4] media: i2c: vd56g3: " Joshua Crofts
2026-11-10 14:20   ` Benjamin Mugnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e43e01a5-4121-4ca4-8216-8f20728759d1@foss.st.com \
    --to=benjamin.mugnier@foss.st.com \
    --cc=crofts@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=david@ixit.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sylvain.petinot@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®