* [PATCH 1/4] media: i2c: imx355: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 [PATCH 0/4] media: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
@ 2026-11-10 14:03 ` Joshua Crofts
2026-11-10 14:31 ` Dave Stevenson
2026-11-10 14:03 ` [PATCH 2/4] media: i2c: tc358746: " Joshua Crofts
` (2 subsequent siblings)
3 siblings, 1 reply; 8+ messages in thread
From: Joshua Crofts @ 2026-11-10 14:03 UTC (permalink / raw)
To: Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Benjamin Mugnier, Sylvain Petinot
Cc: linux-media, linux-kernel, Joshua Crofts
Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.
Remove the redundant function calls.
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
drivers/media/i2c/imx355.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
index c0dafabf5dc9ad6237c9c9380d6122edfedc96f3..89e42312265822428cbf0b909627c66415b3282f 100644
--- a/drivers/media/i2c/imx355.c
+++ b/drivers/media/i2c/imx355.c
@@ -1298,7 +1298,6 @@ static int imx355_probe(struct i2c_client *client)
error_subdev_cleanup_runtime_pm:
pm_runtime_disable(imx355->dev);
pm_runtime_set_suspended(imx355->dev);
- pm_runtime_dont_use_autosuspend(imx355->dev);
v4l2_subdev_cleanup(&imx355->sd);
error_media_entity_free:
media_entity_cleanup(&imx355->sd.entity);
@@ -1329,7 +1328,6 @@ static void imx355_remove(struct i2c_client *client)
pm_runtime_set_suspended(imx355->dev);
}
- pm_runtime_dont_use_autosuspend(imx355->dev);
}
static const struct acpi_device_id imx355_acpi_ids[] __maybe_unused = {
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/4] media: i2c: imx355: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 ` [PATCH 1/4] media: i2c: imx355: " Joshua Crofts
@ 2026-11-10 14:31 ` Dave Stevenson
0 siblings, 0 replies; 8+ messages in thread
From: Dave Stevenson @ 2026-11-10 14:31 UTC (permalink / raw)
To: Joshua Crofts
Cc: Sakari Ailus, David Heidelberg, Mauro Carvalho Chehab,
Benjamin Mugnier, Sylvain Petinot, linux-media, linux-kernel
On Tue, 10 Nov 2026 at 14:03, Joshua Crofts <crofts@kernel.org> wrote:
>
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
Acked-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> ---
> drivers/media/i2c/imx355.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/imx355.c b/drivers/media/i2c/imx355.c
> index c0dafabf5dc9ad6237c9c9380d6122edfedc96f3..89e42312265822428cbf0b909627c66415b3282f 100644
> --- a/drivers/media/i2c/imx355.c
> +++ b/drivers/media/i2c/imx355.c
> @@ -1298,7 +1298,6 @@ static int imx355_probe(struct i2c_client *client)
> error_subdev_cleanup_runtime_pm:
> pm_runtime_disable(imx355->dev);
> pm_runtime_set_suspended(imx355->dev);
> - pm_runtime_dont_use_autosuspend(imx355->dev);
> v4l2_subdev_cleanup(&imx355->sd);
> error_media_entity_free:
> media_entity_cleanup(&imx355->sd.entity);
> @@ -1329,7 +1328,6 @@ static void imx355_remove(struct i2c_client *client)
> pm_runtime_set_suspended(imx355->dev);
> }
>
> - pm_runtime_dont_use_autosuspend(imx355->dev);
> }
>
> static const struct acpi_device_id imx355_acpi_ids[] __maybe_unused = {
>
> --
> 2.47.3
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 2/4] media: i2c: tc358746: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 [PATCH 0/4] media: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-11-10 14:03 ` [PATCH 1/4] media: i2c: imx355: " Joshua Crofts
@ 2026-11-10 14:03 ` Joshua Crofts
2026-11-10 14:03 ` [PATCH 3/4] media: i2c: vd55g1: " Joshua Crofts
2026-11-10 14:03 ` [PATCH 4/4] media: i2c: vd56g3: " Joshua Crofts
3 siblings, 0 replies; 8+ messages in thread
From: Joshua Crofts @ 2026-11-10 14:03 UTC (permalink / raw)
To: Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Benjamin Mugnier, Sylvain Petinot
Cc: linux-media, linux-kernel, Joshua Crofts
Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.
Remove the redundant function calls.
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
drivers/media/i2c/tc358746.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/tc358746.c b/drivers/media/i2c/tc358746.c
index 91d26a6340230186239b7586e73345fb755c5164..d123a530bb879d31111e971c702bb6f96794a8e2 100644
--- a/drivers/media/i2c/tc358746.c
+++ b/drivers/media/i2c/tc358746.c
@@ -1596,7 +1596,6 @@ static int tc358746_probe(struct i2c_client *client)
err_pm:
pm_runtime_disable(dev);
pm_runtime_set_suspended(dev);
- pm_runtime_dont_use_autosuspend(dev);
v4l2_ctrl_handler_free(&tc358746->ctrl_hdl);
err_fwnode:
v4l2_fwnode_endpoint_free(&tc358746->csi_vep);
@@ -1622,7 +1621,6 @@ static void tc358746_remove(struct i2c_client *client)
pm_runtime_disable(sd->dev);
pm_runtime_set_suspended(sd->dev);
- pm_runtime_dont_use_autosuspend(sd->dev);
}
/*
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH 3/4] media: i2c: vd55g1: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 [PATCH 0/4] media: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
2026-11-10 14:03 ` [PATCH 1/4] media: i2c: imx355: " Joshua Crofts
2026-11-10 14:03 ` [PATCH 2/4] media: i2c: tc358746: " Joshua Crofts
@ 2026-11-10 14:03 ` Joshua Crofts
2026-11-10 14:20 ` Benjamin Mugnier
2026-11-10 14:03 ` [PATCH 4/4] media: i2c: vd56g3: " Joshua Crofts
3 siblings, 1 reply; 8+ messages in thread
From: Joshua Crofts @ 2026-11-10 14:03 UTC (permalink / raw)
To: Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Benjamin Mugnier, Sylvain Petinot
Cc: linux-media, linux-kernel, Joshua Crofts
Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.
Remove the redundant function calls.
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
drivers/media/i2c/vd55g1.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
index 3a3ce32b0610eb23d42b622f2173a505df120176..8ea68dc9b1d99d11a7678138a5b6f7147b595f0a 100644
--- a/drivers/media/i2c/vd55g1.c
+++ b/drivers/media/i2c/vd55g1.c
@@ -2053,7 +2053,6 @@ static int vd55g1_probe(struct i2c_client *client)
err_power_off:
pm_runtime_disable(dev);
pm_runtime_put_noidle(dev);
- pm_runtime_dont_use_autosuspend(dev);
vd55g1_power_off(dev);
return ret;
@@ -2070,7 +2069,6 @@ static void vd55g1_remove(struct i2c_client *client)
if (!pm_runtime_status_suspended(&client->dev))
vd55g1_power_off(&client->dev);
pm_runtime_set_suspended(&client->dev);
- pm_runtime_dont_use_autosuspend(&client->dev);
}
static const struct of_device_id vd55g1_dt_ids[] = {
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 3/4] media: i2c: vd55g1: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 ` [PATCH 3/4] media: i2c: vd55g1: " Joshua Crofts
@ 2026-11-10 14:20 ` Benjamin Mugnier
0 siblings, 0 replies; 8+ messages in thread
From: Benjamin Mugnier @ 2026-11-10 14:20 UTC (permalink / raw)
To: Joshua Crofts, Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Sylvain Petinot
Cc: linux-media, linux-kernel
Hi Joshua,
Le 10/11/2026 à 15:03, Joshua Crofts a écrit :
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
That's an easy one. Thank you.
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/vd55g1.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/vd55g1.c b/drivers/media/i2c/vd55g1.c
> index 3a3ce32b0610eb23d42b622f2173a505df120176..8ea68dc9b1d99d11a7678138a5b6f7147b595f0a 100644
> --- a/drivers/media/i2c/vd55g1.c
> +++ b/drivers/media/i2c/vd55g1.c
> @@ -2053,7 +2053,6 @@ static int vd55g1_probe(struct i2c_client *client)
> err_power_off:
> pm_runtime_disable(dev);
> pm_runtime_put_noidle(dev);
> - pm_runtime_dont_use_autosuspend(dev);
> vd55g1_power_off(dev);
>
> return ret;
> @@ -2070,7 +2069,6 @@ static void vd55g1_remove(struct i2c_client *client)
> if (!pm_runtime_status_suspended(&client->dev))
> vd55g1_power_off(&client->dev);
> pm_runtime_set_suspended(&client->dev);
> - pm_runtime_dont_use_autosuspend(&client->dev);
> }
>
> static const struct of_device_id vd55g1_dt_ids[] = {
>
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 4/4] media: i2c: vd56g3: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 [PATCH 0/4] media: remove redundant pm_runtime_dont_use_autosuspend() calls Joshua Crofts
` (2 preceding siblings ...)
2026-11-10 14:03 ` [PATCH 3/4] media: i2c: vd55g1: " Joshua Crofts
@ 2026-11-10 14:03 ` Joshua Crofts
2026-11-10 14:20 ` Benjamin Mugnier
3 siblings, 1 reply; 8+ messages in thread
From: Joshua Crofts @ 2026-11-10 14:03 UTC (permalink / raw)
To: Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Benjamin Mugnier, Sylvain Petinot
Cc: linux-media, linux-kernel, Joshua Crofts
Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
driver core is now responsible for undoing any
pm_runtime_use_autosuspend() calls on driver exit.
Remove the redundant function calls.
Signed-off-by: Joshua Crofts <crofts@kernel.org>
---
drivers/media/i2c/vd56g3.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c
index a42210d0ab8d54a9132a5077875138c2440152bb..e4ad01973a24201a20dd43c86ac6de9817889049 100644
--- a/drivers/media/i2c/vd56g3.c
+++ b/drivers/media/i2c/vd56g3.c
@@ -1538,7 +1538,6 @@ static int vd56g3_probe(struct i2c_client *client)
err_power_off:
pm_runtime_disable(dev);
pm_runtime_put_noidle(dev);
- pm_runtime_dont_use_autosuspend(dev);
vd56g3_power_off(dev);
return ret;
@@ -1555,7 +1554,6 @@ static void vd56g3_remove(struct i2c_client *client)
if (!pm_runtime_status_suspended(sensor->dev))
vd56g3_power_off(sensor->dev);
pm_runtime_set_suspended(sensor->dev);
- pm_runtime_dont_use_autosuspend(sensor->dev);
}
static const struct of_device_id vd56g3_dt_ids[] = {
--
2.47.3
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 4/4] media: i2c: vd56g3: remove redundant pm_runtime_dont_use_autosuspend() calls
2026-11-10 14:03 ` [PATCH 4/4] media: i2c: vd56g3: " Joshua Crofts
@ 2026-11-10 14:20 ` Benjamin Mugnier
0 siblings, 0 replies; 8+ messages in thread
From: Benjamin Mugnier @ 2026-11-10 14:20 UTC (permalink / raw)
To: Joshua Crofts, Sakari Ailus, Dave Stevenson, David Heidelberg,
Mauro Carvalho Chehab, Sylvain Petinot
Cc: linux-media, linux-kernel
Le 10/11/2026 à 15:03, Joshua Crofts a écrit :
> Since commit d1706f9da9f4 ("PM: runtime: call pm_runtime_dont_use_autosuspend() on reinit()"),
> driver core is now responsible for undoing any
> pm_runtime_use_autosuspend() calls on driver exit.
>
> Remove the redundant function calls.
>
> Signed-off-by: Joshua Crofts <crofts@kernel.org>
Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com>
> ---
> drivers/media/i2c/vd56g3.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/media/i2c/vd56g3.c b/drivers/media/i2c/vd56g3.c
> index a42210d0ab8d54a9132a5077875138c2440152bb..e4ad01973a24201a20dd43c86ac6de9817889049 100644
> --- a/drivers/media/i2c/vd56g3.c
> +++ b/drivers/media/i2c/vd56g3.c
> @@ -1538,7 +1538,6 @@ static int vd56g3_probe(struct i2c_client *client)
> err_power_off:
> pm_runtime_disable(dev);
> pm_runtime_put_noidle(dev);
> - pm_runtime_dont_use_autosuspend(dev);
> vd56g3_power_off(dev);
>
> return ret;
> @@ -1555,7 +1554,6 @@ static void vd56g3_remove(struct i2c_client *client)
> if (!pm_runtime_status_suspended(sensor->dev))
> vd56g3_power_off(sensor->dev);
> pm_runtime_set_suspended(sensor->dev);
> - pm_runtime_dont_use_autosuspend(sensor->dev);
> }
>
> static const struct of_device_id vd56g3_dt_ids[] = {
>
--
Regards,
Benjamin
^ permalink raw reply [flat|nested] 8+ messages in thread