* [PATCH v3 36/50] ARM: at91: add support in SoC driver for new sam9x7
@ 2023-07-28 10:29 Varshini Rajendran
2023-12-19 10:11 ` Nicolas Ferre
0 siblings, 1 reply; 2+ messages in thread
From: Varshini Rajendran @ 2023-07-28 10:29 UTC (permalink / raw)
To: nicolas.ferre, alexandre.belloni, claudiu.beznea, mihai.sain,
varshini.rajendran, linux-arm-kernel, linux-kernel
Add support for SAM9X7 SoC in the SoC driver.
Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++
drivers/soc/atmel/soc.h | 9 +++++++++
2 files changed, 32 insertions(+)
diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
index cc9a3e107479..cae3452cbc60 100644
--- a/drivers/soc/atmel/soc.c
+++ b/drivers/soc/atmel/soc.c
@@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = {
AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH,
"sam9x60 8MiB SDRAM SiP", "sam9x60"),
#endif
+#ifdef CONFIG_SOC_SAM9X7
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH,
+ "sam9x72", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
+ AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH,
+ "sam9x70", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 1Gb DDR3L SiP ", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 512Mb DDR2 SiP", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 128Mb DDR2 SiP", "sam9x7"),
+ AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH,
+ AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
+ "sam9x75 2Gb DDR3L SiP", "sam9x7"),
+#endif
#ifdef CONFIG_SOC_SAMA5
AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH,
diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h
index 7a9f47ce85fb..26dd26b4f179 100644
--- a/drivers/soc/atmel/soc.h
+++ b/drivers/soc/atmel/soc.h
@@ -45,6 +45,7 @@ at91_soc_init(const struct at91_soc *socs);
#define AT91SAM9N12_CIDR_MATCH 0x019a07a0
#define SAM9X60_CIDR_MATCH 0x019b35a0
#define SAMA7G5_CIDR_MATCH 0x00162100
+#define SAM9X7_CIDR_MATCH 0x09750020
#define AT91SAM9M11_EXID_MATCH 0x00000001
#define AT91SAM9M10_EXID_MATCH 0x00000002
@@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs);
#define SAMA7G54_D2G_EXID_MATCH 0x00000020
#define SAMA7G54_D4G_EXID_MATCH 0x00000028
+#define SAM9X75_EXID_MATCH 0x00000000
+#define SAM9X72_EXID_MATCH 0x00000004
+#define SAM9X70_EXID_MATCH 0x00000005
+#define SAM9X75_D1G_EXID_MATCH 0x00000001
+#define SAM9X75_D5M_EXID_MATCH 0x00000002
+#define SAM9X75_D1M_EXID_MATCH 0x00000003
+#define SAM9X75_D2G_EXID_MATCH 0x00000006
+
#define AT91SAM9XE128_CIDR_MATCH 0x329973a0
#define AT91SAM9XE256_CIDR_MATCH 0x329a93a0
#define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v3 36/50] ARM: at91: add support in SoC driver for new sam9x7
2023-07-28 10:29 [PATCH v3 36/50] ARM: at91: add support in SoC driver for new sam9x7 Varshini Rajendran
@ 2023-12-19 10:11 ` Nicolas Ferre
0 siblings, 0 replies; 2+ messages in thread
From: Nicolas Ferre @ 2023-12-19 10:11 UTC (permalink / raw)
To: Varshini Rajendran, alexandre.belloni, claudiu.beznea,
mihai.sain, linux-arm-kernel, linux-kernel
On 28/07/2023 at 12:29, Varshini Rajendran wrote:
> Add support for SAM9X7 SoC in the SoC driver.
>
> Signed-off-by: Varshini Rajendran <varshini.rajendran@microchip.com>
> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
> drivers/soc/atmel/soc.c | 23 +++++++++++++++++++++++
> drivers/soc/atmel/soc.h | 9 +++++++++
> 2 files changed, 32 insertions(+)
>
> diff --git a/drivers/soc/atmel/soc.c b/drivers/soc/atmel/soc.c
> index cc9a3e107479..cae3452cbc60 100644
> --- a/drivers/soc/atmel/soc.c
> +++ b/drivers/soc/atmel/soc.c
> @@ -101,6 +101,29 @@ static const struct at91_soc socs[] __initconst = {
> AT91_CIDR_VERSION_MASK, SAM9X60_D6K_EXID_MATCH,
> "sam9x60 8MiB SDRAM SiP", "sam9x60"),
> #endif
> +#ifdef CONFIG_SOC_SAM9X7
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X72_EXID_MATCH,
> + "sam9x72", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> + AT91_CIDR_VERSION_MASK, SAM9X70_EXID_MATCH,
> + "sam9x70", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 1Gb DDR3L SiP ", "sam9x7"),
I don't want that we introduce more sizes in "bits" instead of "bytes"
in this file.
I know it's what is advertised in datasheets, but we're software people
who count these sizes in bytes, so let's do the conversion for the users.
BTW: this file will need to be updated with this statement in mind.
Best regards,
Nicolas
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D5M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 512Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D1M_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 128Mb DDR2 SiP", "sam9x7"),
> + AT91_SOC(SAM9X7_CIDR_MATCH, SAM9X75_D2G_EXID_MATCH,
> + AT91_CIDR_VERSION_MASK, SAM9X75_EXID_MATCH,
> + "sam9x75 2Gb DDR3L SiP", "sam9x7"),
> +#endif
> #ifdef CONFIG_SOC_SAMA5
> AT91_SOC(SAMA5D2_CIDR_MATCH, AT91_CIDR_MATCH_MASK,
> AT91_CIDR_VERSION_MASK, SAMA5D21CU_EXID_MATCH,
> diff --git a/drivers/soc/atmel/soc.h b/drivers/soc/atmel/soc.h
> index 7a9f47ce85fb..26dd26b4f179 100644
> --- a/drivers/soc/atmel/soc.h
> +++ b/drivers/soc/atmel/soc.h
> @@ -45,6 +45,7 @@ at91_soc_init(const struct at91_soc *socs);
> #define AT91SAM9N12_CIDR_MATCH 0x019a07a0
> #define SAM9X60_CIDR_MATCH 0x019b35a0
> #define SAMA7G5_CIDR_MATCH 0x00162100
> +#define SAM9X7_CIDR_MATCH 0x09750020
Apha-numerial order please.
>
> #define AT91SAM9M11_EXID_MATCH 0x00000001
> #define AT91SAM9M10_EXID_MATCH 0x00000002
> @@ -74,6 +75,14 @@ at91_soc_init(const struct at91_soc *socs);
> #define SAMA7G54_D2G_EXID_MATCH 0x00000020
> #define SAMA7G54_D4G_EXID_MATCH 0x00000028
>
> +#define SAM9X75_EXID_MATCH 0x00000000
> +#define SAM9X72_EXID_MATCH 0x00000004
> +#define SAM9X70_EXID_MATCH 0x00000005
> +#define SAM9X75_D1G_EXID_MATCH 0x00000001
> +#define SAM9X75_D5M_EXID_MATCH 0x00000002
> +#define SAM9X75_D1M_EXID_MATCH 0x00000003
> +#define SAM9X75_D2G_EXID_MATCH 0x00000006
> +
Ditto
> #define AT91SAM9XE128_CIDR_MATCH 0x329973a0
> #define AT91SAM9XE256_CIDR_MATCH 0x329a93a0
> #define AT91SAM9XE512_CIDR_MATCH 0x329aa3a0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-19 10:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-28 10:29 [PATCH v3 36/50] ARM: at91: add support in SoC driver for new sam9x7 Varshini Rajendran
2023-12-19 10:11 ` Nicolas Ferre
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®