From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthieu Castet <castet.matthieu@free.fr>,
Stanislaw Gruszka <stf_xl@wp.pl>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: [PATCH 1/4] ueagle-atm: Delete error messages for failed memory allocations in two functions
Date: Fri, 19 May 2017 19:47:27 +0200 [thread overview]
Message-ID: <e465c4ba-fe61-24c0-6e5b-b37abcf87d2c@users.sourceforge.net> (raw)
In-Reply-To: <d1c7c5d1-68b8-bbfc-8d0b-71a8e6cdd152@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 19 May 2017 19:02:01 +0200
Omit two extra messages for memory allocation failures in these functions.
This issue was detected by using the Coccinelle software.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/usb/atm/ueagle-atm.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c
index df67815f74e6..16fd87df69e1 100644
--- a/drivers/usb/atm/ueagle-atm.c
+++ b/drivers/usb/atm/ueagle-atm.c
@@ -868,10 +868,8 @@ static int uea_idma_write(struct uea_softc *sc, const void *data, u32 size)
int bytes_read;
xfer_buff = kmemdup(data, size, GFP_KERNEL);
- if (!xfer_buff) {
- uea_err(INS_TO_USBDEV(sc), "can't allocate xfer_buff\n");
+ if (!xfer_buff)
return ret;
- }
ret = usb_bulk_msg(sc->usb_dev,
usb_sndbulkpipe(sc->usb_dev, UEA_IDMA_PIPE),
@@ -1147,10 +1145,8 @@ static int uea_request(struct uea_softc *sc,
int ret = -ENOMEM;
xfer_buff = kmemdup(data, size, GFP_KERNEL);
- if (!xfer_buff) {
- uea_err(INS_TO_USBDEV(sc), "can't allocate xfer_buff\n");
+ if (!xfer_buff)
return ret;
- }
ret = usb_control_msg(sc->usb_dev, usb_sndctrlpipe(sc->usb_dev, 0),
UCDC_SEND_ENCAPSULATED_COMMAND,
--
2.13.0
next prev parent reply other threads:[~2017-05-19 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-19 17:45 [PATCH 0/4] ueagle-atm: Adjustments for eight function implementations SF Markus Elfring
2017-05-19 17:47 ` SF Markus Elfring [this message]
2017-05-19 17:49 ` [PATCH 2/4] ueagle-atm: Improve a size determination in uea_bind() SF Markus Elfring
2017-05-19 17:50 ` [PATCH 3/4] ueagle-atm: Delete unnecessary return statements in two functions SF Markus Elfring
2017-05-19 17:51 ` [PATCH 4/4] ueagle-atm: Adjust three checks for null pointers SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e465c4ba-fe61-24c0-6e5b-b37abcf87d2c@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=castet.matthieu@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stf_xl@wp.pl \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®