From: Dan Scally <dan.scally@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: "jempty.liang" <imntjempty@163.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
mchehab@kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mali-c55: Fix NULL dev stream alert for tpg sub-device
Date: Tue, 13 Jan 2026 14:12:06 +0000 [thread overview]
Message-ID: <e48188b6-111f-45c0-a6a2-ce1bc1411878@ideasonboard.com> (raw)
In-Reply-To: <aWYhGQcDVRDTyvxj@kekkonen.localdomain>
On 13/01/2026 10:40, Sakari Ailus wrote:
> Hi Jacopo,
>
> On Tue, Jan 13, 2026 at 09:55:10AM +0100, Jacopo Mondi wrote:
>> I wonder if v4l2_device_register_subdev() shouldn't WARN or if return
>> an error if sd->dev is not initialized. Laurent, Sakari: opinions ?
>
> I might even return an error but I wonder what would break. Perhaps indeed
> could start with a warning?
>
It looks like it's only used for dev_*() printks, unless I'm missing something. Thanks Jempty for
spotting the problem!
Dan
prev parent reply other threads:[~2026-01-13 14:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-13 7:57 jempty.liang
2026-01-13 8:55 ` Jacopo Mondi
2026-01-13 10:40 ` Sakari Ailus
2026-01-13 12:43 ` Jacopo Mondi
2026-01-13 19:25 ` Sakari Ailus
2026-01-13 14:12 ` Dan Scally [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48188b6-111f-45c0-a6a2-ce1bc1411878@ideasonboard.com \
--to=dan.scally@ideasonboard.com \
--cc=imntjempty@163.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®