* [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning
@ 2023-10-07 0:55 Randy Dunlap
2023-10-09 21:47 ` Lyude Paul
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-10-07 0:55 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Dave Airlie, Danilo Krummrich, Karol Herbst,
Lyude Paul, dri-devel, nouveau
include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX
on line 49 - I thought it was a doc line
Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Danilo Krummrich <dakr@redhat.com>
Cc: Karol Herbst <kherbst@redhat.com>
Cc: Lyude Paul <lyude@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Cc: nouveau@lists.freedesktop.org
---
include/uapi/drm/nouveau_drm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -- a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h
--- a/include/uapi/drm/nouveau_drm.h
+++ b/include/uapi/drm/nouveau_drm.h
@@ -45,8 +45,8 @@ extern "C" {
#define NOUVEAU_GETPARAM_HAS_BO_USAGE 15
#define NOUVEAU_GETPARAM_HAS_PAGEFLIP 16
-/**
- * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX
+/*
+ * NOUVEAU_GETPARAM_EXEC_PUSH_MAX - query max pushes through getparam
*
* Query the maximum amount of IBs that can be pushed through a single
* &drm_nouveau_exec structure and hence a single &DRM_IOCTL_NOUVEAU_EXEC
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning
2023-10-07 0:55 [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning Randy Dunlap
@ 2023-10-09 21:47 ` Lyude Paul
0 siblings, 0 replies; 2+ messages in thread
From: Lyude Paul @ 2023-10-09 21:47 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel
Cc: Dave Airlie, Danilo Krummrich, Karol Herbst, dri-devel, nouveau
Reviewed-by: Lyude Paul <lyude@redhat.com>
On Fri, 2023-10-06 at 17:55 -0700, Randy Dunlap wrote:
> include/uapi/drm/nouveau_drm.h:49: warning: Cannot understand * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX
> on line 49 - I thought it was a doc line
>
> Fixes: d59e75eef52d ("drm/nouveau: exec: report max pushs through getparam")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Danilo Krummrich <dakr@redhat.com>
> Cc: Karol Herbst <kherbst@redhat.com>
> Cc: Lyude Paul <lyude@redhat.com>
> Cc: dri-devel@lists.freedesktop.org
> Cc: nouveau@lists.freedesktop.org
> ---
> include/uapi/drm/nouveau_drm.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -- a/include/uapi/drm/nouveau_drm.h b/include/uapi/drm/nouveau_drm.h
> --- a/include/uapi/drm/nouveau_drm.h
> +++ b/include/uapi/drm/nouveau_drm.h
> @@ -45,8 +45,8 @@ extern "C" {
> #define NOUVEAU_GETPARAM_HAS_BO_USAGE 15
> #define NOUVEAU_GETPARAM_HAS_PAGEFLIP 16
>
> -/**
> - * @NOUVEAU_GETPARAM_EXEC_PUSH_MAX
> +/*
> + * NOUVEAU_GETPARAM_EXEC_PUSH_MAX - query max pushes through getparam
> *
> * Query the maximum amount of IBs that can be pushed through a single
> * &drm_nouveau_exec structure and hence a single &DRM_IOCTL_NOUVEAU_EXEC
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-09 21:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-07 0:55 [PATCH] drm/nouveau: exec: fix ioctl kernel-doc warning Randy Dunlap
2023-10-09 21:47 ` Lyude Paul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®