From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Guenter Roeck <linux@roeck-us.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Yueyao Zhu <yueyao@google.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Hans de Goede <hdegoede@redhat.com>,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 3/5] staging: typec: pd: Document struct pd_message
Date: Mon, 11 Sep 2017 13:09:42 +0300 [thread overview]
Message-ID: <e49fe70e-2a9d-1d6f-ed68-32b4f3a8b0d8@cogentembedded.com> (raw)
In-Reply-To: <1505075825-15700-3-git-send-email-linux@roeck-us.net>
Hello.
On 9/10/2017 11:37 PM, Guenter Roeck wrote:
> struct pd_message is the format of a PD message as seen on the wire.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/staging/typec/pd.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/staging/typec/pd.h b/drivers/staging/typec/pd.h
> index 30b32ad72acd..42a10883a2cb 100644
> --- a/drivers/staging/typec/pd.h
> +++ b/drivers/staging/typec/pd.h
> @@ -104,6 +104,11 @@ static inline unsigned int pd_header_msgid_le(__le16 header)
>
> #define PD_MAX_PAYLOAD 7
>
> +/*
The kernel-doc comments (to which this comment looks alike) should start
with /**.
> + * struct pd_message - PD message as seen on wire
> + * @header: PD message header
> + * @payload: PD message payload
> + */
> struct pd_message {
> __le16 header;
> __le32 payload[PD_MAX_PAYLOAD];
MBR, Sergei
next prev parent reply other threads:[~2017-09-11 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-10 20:37 [PATCH 1/5] staging: typec: tcpm: Drop commented out code Guenter Roeck
2017-09-10 20:37 ` [PATCH 2/5] staging: typec: tcpm: Document data structures Guenter Roeck
2017-09-10 20:37 ` [PATCH 3/5] staging: typec: pd: Document struct pd_message Guenter Roeck
2017-09-11 10:09 ` Sergei Shtylyov [this message]
2017-09-10 20:37 ` [PATCH 4/5] typec: tcpm: Move out of staging Guenter Roeck
2017-09-10 20:46 ` Joe Perches
2017-09-10 21:18 ` Guenter Roeck
2017-09-10 20:37 ` [PATCH 5/5] usb: typec: fusb302: " Guenter Roeck
2017-09-11 16:23 ` [PATCH 1/5] staging: typec: tcpm: Drop commented out code Greg Kroah-Hartman
2017-09-11 17:37 ` Guenter Roeck
2017-09-11 18:26 ` Greg Kroah-Hartman
2017-09-11 19:56 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e49fe70e-2a9d-1d6f-ed68-32b4f3a8b0d8@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=badhri@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=yueyao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®