mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: admiyo@os.amperecomputing.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Matt Johnston <matt@codeconstruct.com.au>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	 Sudeep Holla <sudeep.holla@arm.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Huisong Li <lihuisong@huawei.com>
Subject: Re: [PATCH v11 0/1] MCTP Over PCC Transport
Date: Mon, 06 Jan 2025 09:05:48 +0800	[thread overview]
Message-ID: <e4c5b40a906a560f9a333d8e9d7c556ad99d63fa.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250104035430.625147-1-admiyo@os.amperecomputing.com>

Hi Adam,
> Changes in V11:
> - Switch Big Endian data types to machine local for PCC header

This seems suspicious; the concept of "machine local" may not be
consistent between channel endpoints (ie, system firmware and this
driver). Looking at DSP0292, and the PCC channel spec, it looks like
these should be explicitly little-endian, no?

The warnings you were seeing in v10 seemed to be an issue of direct
accesses to the __be32 types in struct mctp_pcc_hdr - ie., without
be32_to_cpu() accessors. If you keep the endian-annotated types (but
__le32 instead), and use the appropriate le32_to_cpu() accessors, that
should address those warnings, while keeping the driver endian-safe.

Cheers,


Jeremy


  parent reply	other threads:[~2025-01-06  1:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-04  3:54 admiyo
2025-01-04  3:54 ` [PATCH v11 1/1] mctp pcc: Implement MCTP over " admiyo
2025-01-06  1:05 ` Jeremy Kerr [this message]
2025-01-06 17:30   ` [PATCH v11 0/1] MCTP Over " Adam Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e4c5b40a906a560f9a333d8e9d7c556ad99d63fa.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=admiyo@os.amperecomputing.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=lihuisong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®