* [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe() @ 2018-02-13 21:17 ` SF Markus Elfring 2018-02-13 22:21 ` Chanwoo Choi [not found] ` <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcms1p5> 0 siblings, 2 replies; 3+ messages in thread From: SF Markus Elfring @ 2018-02-13 21:17 UTC (permalink / raw) To: linux-arm-kernel, linux-pm, linux-samsung-soc, Chanwoo Choi, Krzysztof Kozlowski, Kukjin Kim, Kyungmin Park, MyungJoo Ham Cc: LKML, kernel-janitors From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 13 Feb 2018 22:10:42 +0100 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/devfreq/event/exynos-ppmu.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c index d96e3dc71cf8..72ac9113500d 100644 --- a/drivers/devfreq/event/exynos-ppmu.c +++ b/drivers/devfreq/event/exynos-ppmu.c @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev) size = sizeof(struct devfreq_event_dev *) * info->num_events; info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL); - if (!info->edev) { - dev_err(&pdev->dev, - "failed to allocate memory devfreq-event devices\n"); + if (!info->edev) return -ENOMEM; - } + edev = info->edev; platform_set_drvdata(pdev, info); -- 2.16.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe() 2018-02-13 21:17 ` [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe() SF Markus Elfring @ 2018-02-13 22:21 ` Chanwoo Choi [not found] ` <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcms1p5> 1 sibling, 0 replies; 3+ messages in thread From: Chanwoo Choi @ 2018-02-13 22:21 UTC (permalink / raw) To: SF Markus Elfring, linux-arm-kernel, linux-pm, linux-samsung-soc, Krzysztof Kozlowski, Kukjin Kim, Kyungmin Park, MyungJoo Ham Cc: LKML, kernel-janitors On 2018년 02월 14일 06:17, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 13 Feb 2018 22:10:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/devfreq/event/exynos-ppmu.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > index d96e3dc71cf8..72ac9113500d 100644 > --- a/drivers/devfreq/event/exynos-ppmu.c > +++ b/drivers/devfreq/event/exynos-ppmu.c > @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev) > > size = sizeof(struct devfreq_event_dev *) * info->num_events; > info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL); > - if (!info->edev) { > - dev_err(&pdev->dev, > - "failed to allocate memory devfreq-event devices\n"); > + if (!info->edev) > return -ENOMEM; > - } > + > edev = info->edev; > platform_set_drvdata(pdev, info); > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcms1p5>]
* RE: Re: [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe() [not found] ` <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcms1p5> @ 2018-02-22 5:14 ` MyungJoo Ham 0 siblings, 0 replies; 3+ messages in thread From: MyungJoo Ham @ 2018-02-22 5:14 UTC (permalink / raw) To: Chanwoo Choi, SF Markus Elfring, linux-arm-kernel, linux-pm, linux-samsung-soc, Krzysztof Kozlowski, Kukjin Kim, Kyungmin Park Cc: LKML, kernel-janitors > On 2018년 02월 14일 06:17, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Tue, 13 Feb 2018 22:10:42 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > --- > > drivers/devfreq/event/exynos-ppmu.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/devfreq/event/exynos-ppmu.c b/drivers/devfreq/event/exynos-ppmu.c > > index d96e3dc71cf8..72ac9113500d 100644 > > --- a/drivers/devfreq/event/exynos-ppmu.c > > +++ b/drivers/devfreq/event/exynos-ppmu.c > > @@ -627,11 +627,9 @@ static int exynos_ppmu_probe(struct platform_device *pdev) > > > > size = sizeof(struct devfreq_event_dev *) * info->num_events; > > info->edev = devm_kzalloc(&pdev->dev, size, GFP_KERNEL); > > - if (!info->edev) { > > - dev_err(&pdev->dev, > > - "failed to allocate memory devfreq-event devices\n"); > > + if (!info->edev) > > return -ENOMEM; > > - } > > + > > edev = info->edev; > > platform_set_drvdata(pdev, info); > > > > > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-22 5:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcas1p1.samsung.com>
2018-02-13 21:17 ` [PATCH] PM / devfreq: exynos-ppmu: Delete an error message for a failed memory allocation in exynos_ppmu_probe() SF Markus Elfring
2018-02-13 22:21 ` Chanwoo Choi
[not found] ` <CGME20180213211754epcas1p12c743dac97dbc187c46206bc2fa16c78@epcms1p5>
2018-02-22 5:14 ` MyungJoo Ham
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®