From: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
To: <arnd@arndb.de>, <catalin.marinas@arm.com>, <rostedt@goodmis.org>
Cc: <gregkh@linuxfoundation.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<maz@kernel.org>, <quic_psodagud@quicinc.com>,
<quic_tsoni@quicinc.com>, <will@kernel.org>,
Sai Prakash Ranjan <quic_saipraka@quicinc.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>
Subject: [PATCHv14 9/9] soc: qcom: geni: Disable MMIO tracing for GENI SE
Date: Wed, 4 May 2022 16:58:28 +0530 [thread overview]
Message-ID: <e4e2522c6626e8ecdd3a3ce6d0ac85aba41fae38.1651663123.git.quic_saipraka@quicinc.com> (raw)
In-Reply-To: <cover.1651663123.git.quic_saipraka@quicinc.com>
Disable MMIO tracing for GENI SE driver to prevent excessive
logging. Any access over serial console would involve a lot of
TX and RX register accesses (and few others), so these MMIO
read/write trace events in these drivers cause a lot of unwanted
noise because of the high frequency of such operations and it is
not very useful tracing these events for such drivers.
Given we want to enable these trace events on development devices
(maybe not production devices) where performance also really
matters so that we don't regress other components by wasting CPU
cycles and memory collecting these traces, it makes more sense to
disable these traces from such drivers.
Also another reason to disable these traces would be to prevent
recursive tracing when we display the trace buffer containing
these MMIO trace events since writing onto serial console would
further record MMIO traces.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
---
drivers/soc/qcom/qcom-geni-se.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index 28a8c0dda66c..a0ceeede450f 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -1,6 +1,9 @@
// SPDX-License-Identifier: GPL-2.0
// Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
+/* Disable MMIO tracing to prevent excessive logging of unwanted MMIO traces */
+#define __DISABLE_TRACE_MMIO__
+
#include <linux/acpi.h>
#include <linux/clk.h>
#include <linux/slab.h>
--
2.33.1
next prev parent reply other threads:[~2022-05-04 11:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 11:28 [PATCHv14 0/9] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 1/9] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 2/9] coresight: etm4x: Use asm-generic IO memory barriers Sai Prakash Ranjan
2022-05-05 23:44 ` Suzuki K Poulose
2022-05-06 3:02 ` Sai Prakash Ranjan
2022-05-06 9:21 ` Suzuki K Poulose
2022-05-06 13:22 ` Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 3/9] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 4/9] drm/meson: " Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 5/9] lib: Add register read/write tracing support Sai Prakash Ranjan
2022-05-11 3:51 ` Sai Prakash Ranjan
2022-05-17 6:41 ` Sai Prakash Ranjan
2022-05-18 14:07 ` Steven Rostedt
2022-05-18 15:18 ` Sai Prakash Ranjan
2022-05-18 16:45 ` Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 6/9] KVM: arm64: Add a flag to disable MMIO trace for nVHE KVM Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 7/9] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2022-05-04 11:28 ` [PATCHv14 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial Sai Prakash Ranjan
2022-05-04 11:28 ` Sai Prakash Ranjan [this message]
2022-05-04 11:32 ` [PATCHv14 0/9] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4e2522c6626e8ecdd3a3ce6d0ac85aba41fae38.1651663123.git.quic_saipraka@quicinc.com \
--to=quic_saipraka@quicinc.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=quic_psodagud@quicinc.com \
--cc=quic_tsoni@quicinc.com \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®