From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: barnabas.czeman@mainlining.org
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Gabriel Gonzales <semfault@disroot.org>,
Kees Cook <kees@kernel.org>, Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>,
Biswapriyo Nath <nathbappai@gmail.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org,
phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht, linux@mainlining.org
Subject: Re: [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges
Date: Tue, 13 Jan 2026 10:45:02 +0100 [thread overview]
Message-ID: <e4f9cdc4-1b3a-44b0-83f1-315c934985ba@oss.qualcomm.com> (raw)
In-Reply-To: <43741f0228b0e0d6b2991417852f890a@mainlining.org>
On 1/13/26 10:25 AM, barnabas.czeman@mainlining.org wrote:
> On 2026-01-13 10:12, Konrad Dybcio wrote:
>> On 1/13/26 10:08 AM, barnabas.czeman@mainlining.org wrote:
>>> On 2026-01-13 10:01, Konrad Dybcio wrote:
>>>> On 1/12/26 9:13 PM, Barnabás Czémán wrote:
>>>>> The device was crashing on boot because the reserved gpio ranges
>>>>> was wrongly defined. Correct the ranges for avoid pinctrl crashing.
>>>>>
>>>>> Fixes: 9b1a6c925c88 ("arm64: dts: qcom: sm6125: Initial support for xiaomi-ginkgo")
>>>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>>>>> ---
>>>>
>>>> That's odd.. were you able to confirm that these values are alright for
>>>> both the Note 8 and the 8T?
>>> Yes, it was tested on both devices. The original devicetree was never boot.
>>
>> Fun..
>>
>>>>
>>>>> arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>>>>> index 666daf4a9fdd..163ecdc7fd6c 100644
>>>>> --- a/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>>>>> +++ b/arch/arm64/boot/dts/qcom/sm6125-xiaomi-ginkgo.dts
>>>>> @@ -296,7 +296,7 @@ &sdhc_2 {
>>>>> };
>>>>>
>>>>> &tlmm {
>>>>> - gpio-reserved-ranges = <22 2>, <28 6>;
>>>>> + gpio-reserved-ranges = <0 4>, <30 4>;
>>>>
>>>> Any chance you know/could deduce what they're connected to and describe
>>>> it, like in x1-crd.dtsi?
>>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/willow-p-oss/drivers/pinctrl/qcom/pinctrl-msm.c#L605
>>> https://github.com/MiCode/Xiaomi_Kernel_OpenSource/blob/ginkgo-p-oss/drivers/pinctrl/qcom/pinctrl-msm.c#L610
>>
>> GPIO0-3 sounds like QUP0 and GPIO30-33 sounds like QUP6
>>
>> My guess would be one goes to a fingerprint scanner and one goes to
>> NFC eSE (or N/C for the device without NFC)
>>
>> Could you scan the downstream devicetree for signals of that?
> NFC is using gpio83, gpio84, gpio85 and gpio95.
I was referring to the NFC eSE (embedded Secure Element) which usually
has a separate connection to the SoC
Konrad
next prev parent reply other threads:[~2026-01-13 9:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 20:13 [PATCH 0/6] Initial Redmi Note 8T support and more Barnabás Czémán
2026-01-12 20:13 ` [PATCH 1/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix msm-id and remove board-id Barnabás Czémán
2026-01-12 22:11 ` Dmitry Baryshkov
2026-01-13 8:52 ` Konrad Dybcio
2026-01-14 9:10 ` Krzysztof Kozlowski
2026-01-12 20:13 ` [PATCH 2/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Correct reserved memory ranges Barnabás Czémán
2026-01-13 8:53 ` Konrad Dybcio
2026-01-13 9:14 ` barnabas.czeman
2026-01-13 9:21 ` Konrad Dybcio
2026-01-14 10:15 ` David Heidelberg
2026-01-14 10:28 ` Konrad Dybcio
2026-01-14 21:55 ` David Heidelberg
2026-01-16 9:52 ` Konrad Dybcio
2026-01-16 11:21 ` David Heidelberg
2026-01-16 11:30 ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 3/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Remove extcon Barnabás Czémán
2026-01-12 22:12 ` Dmitry Baryshkov
2026-01-13 8:59 ` Konrad Dybcio
2026-01-13 9:00 ` Konrad Dybcio
2026-01-13 9:11 ` barnabas.czeman
2026-01-13 9:13 ` Konrad Dybcio
2026-01-12 20:13 ` [PATCH 4/6] arm64: dts: qcom: sm6125-xiaomi-ginkgo: Fix reserved gpio ranges Barnabás Czémán
2026-01-13 9:01 ` Konrad Dybcio
2026-01-13 9:08 ` barnabas.czeman
2026-01-13 9:12 ` Konrad Dybcio
2026-01-13 9:25 ` barnabas.czeman
2026-01-13 9:45 ` Konrad Dybcio [this message]
2026-01-13 14:13 ` Biswapriyo Nath
2026-01-12 20:13 ` [PATCH 5/6] dt-bindings: arm: qcom: Add Xiaomi Redmi Note 8T Barnabás Czémán
2026-01-15 17:37 ` Rob Herring (Arm)
2026-01-12 20:13 ` [PATCH 6/6] arm64: dts: qcom: Add " Barnabás Czémán
2026-01-12 22:15 ` Dmitry Baryshkov
2026-01-12 23:41 ` barnabas.czeman
2026-01-13 0:22 ` Dmitry Baryshkov
2026-01-13 0:49 ` barnabas.czeman
2026-01-13 1:18 ` Dmitry Baryshkov
2026-01-13 8:52 ` Konrad Dybcio
2026-01-13 9:20 ` barnabas.czeman
2026-01-13 9:04 ` Konrad Dybcio
2026-01-16 6:53 ` barnabas.czeman
2026-01-16 9:53 ` Konrad Dybcio
2026-01-16 10:51 ` barnabas.czeman
2026-01-16 11:03 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f9cdc4-1b3a-44b0-83f1-315c934985ba@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=nathbappai@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=semfault@disroot.org \
--cc=tony.luck@intel.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®