[PATCH] misc: gehc: Add SPI ID table

[PATCH] misc: gehc: Add SPI ID table

[Mark Brown]

Currently autoloading for SPI devices does not use the DT ID table, it uses
SPI modalises. Supporting OF modalises is going to be difficult if not
impractical, an attempt was made but has been reverted, so ensure that
module autoloading works for this driver by adding a SPI ID table entry
for the device name part of the compatible - currently only the full
compatible is listed which isn't very idiomatic and won't match the
modalias that is generated.

Fixes: 96c8395e2166 ("spi: Revert modalias changes")
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/misc/gehc-achc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/misc/gehc-achc.c b/drivers/misc/gehc-achc.c
index 02f33bc60c56..4c9c5394da6f 100644
--- a/drivers/misc/gehc-achc.c
+++ b/drivers/misc/gehc-achc.c
@@ -539,6 +539,7 @@ static int gehc_achc_probe(struct spi_device *spi)
 
 static const struct spi_device_id gehc_achc_id[] = {
 	{ "ge,achc", 0 },
+	{ "achc", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(spi, gehc_achc_id);
-- 
2.20.1

Re: [PATCH] misc: gehc: Add SPI ID table

[Martyn Welch]

On Thu, 2021-09-23 at 20:46 +0100, Mark Brown wrote:
> Currently autoloading for SPI devices does not use the DT ID table,
> it uses
> SPI modalises. Supporting OF modalises is going to be difficult if
> not
> impractical, an attempt was made but has been reverted, so ensure
> that
> module autoloading works for this driver by adding a SPI ID table
> entry
> for the device name part of the compatible - currently only the full
> compatible is listed which isn't very idiomatic and won't match the
> modalias that is generated.
> 
> Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> Signed-off-by: Mark Brown <broonie@kernel.org>

Tested-by: Martyn Welch <martyn.welch@collabora.com>

> ---
>  drivers/misc/gehc-achc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/gehc-achc.c b/drivers/misc/gehc-achc.c
> index 02f33bc60c56..4c9c5394da6f 100644
> --- a/drivers/misc/gehc-achc.c
> +++ b/drivers/misc/gehc-achc.c
> @@ -539,6 +539,7 @@ static int gehc_achc_probe(struct spi_device
> *spi)
>  
>  static const struct spi_device_id gehc_achc_id[] = {
>         { "ge,achc", 0 },
> +       { "achc", 0 },
>         { }
>  };
>  MODULE_DEVICE_TABLE(spi, gehc_achc_id);