From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring
Date: Mon, 14 Apr 2025 10:11:20 +0200 [thread overview]
Message-ID: <e52ee383-6803-4b2d-aa30-0f081d3564e0@kernel.org> (raw)
In-Reply-To: <20250413163755.788907-1-ivo.ivanov.ivanov1@gmail.com>
On 13/04/2025 18:37, Ivaylo Ivanov wrote:
> Instead of setting bit 1 (USI_OPTION_CLKSTOP_ON) during USI unconfiguring,
> all the other bits in the USI_OPTION register get inverted, which
> should not happen as that means the clock will keep getting provided
> to the USI IP. Remove the unnecessary tilde.
>
> Fixes: 11e77776b58a ("soc: samsung: usi: add a routine for unconfiguring the ip")
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
Thanks, applied.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-04-14 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-13 16:37 Ivaylo Ivanov
2025-04-14 8:11 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52ee383-6803-4b2d-aa30-0f081d3564e0@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=ivo.ivanov.ivanov1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®