* [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring
@ 2025-04-13 16:37 Ivaylo Ivanov
2025-04-14 8:11 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Ivaylo Ivanov @ 2025-04-13 16:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Alim Akhtar
Cc: linux-samsung-soc, linux-arm-kernel, linux-kernel
Instead of setting bit 1 (USI_OPTION_CLKSTOP_ON) during USI unconfiguring,
all the other bits in the USI_OPTION register get inverted, which
should not happen as that means the clock will keep getting provided
to the USI IP. Remove the unnecessary tilde.
Fixes: 11e77776b58a ("soc: samsung: usi: add a routine for unconfiguring the ip")
Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
---
drivers/soc/samsung/exynos-usi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/samsung/exynos-usi.c b/drivers/soc/samsung/exynos-usi.c
index c5661ac19..5f7bdf3ba 100644
--- a/drivers/soc/samsung/exynos-usi.c
+++ b/drivers/soc/samsung/exynos-usi.c
@@ -233,7 +233,7 @@ static void exynos_usi_unconfigure(void *data)
/* Make sure that we've stopped providing the clock to USI IP */
val = readl(usi->regs + USI_OPTION);
val &= ~USI_OPTION_CLKREQ_ON;
- val |= ~USI_OPTION_CLKSTOP_ON;
+ val |= USI_OPTION_CLKSTOP_ON;
writel(val, usi->regs + USI_OPTION);
/* Set USI block state to reset */
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring
2025-04-13 16:37 [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring Ivaylo Ivanov
@ 2025-04-14 8:11 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2025-04-14 8:11 UTC (permalink / raw)
To: Ivaylo Ivanov, Krzysztof Kozlowski, Alim Akhtar
Cc: linux-samsung-soc, linux-arm-kernel, linux-kernel
On 13/04/2025 18:37, Ivaylo Ivanov wrote:
> Instead of setting bit 1 (USI_OPTION_CLKSTOP_ON) during USI unconfiguring,
> all the other bits in the USI_OPTION register get inverted, which
> should not happen as that means the clock will keep getting provided
> to the USI IP. Remove the unnecessary tilde.
>
> Fixes: 11e77776b58a ("soc: samsung: usi: add a routine for unconfiguring the ip")
> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com>
> ---
Thanks, applied.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-14 8:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-13 16:37 [PATCH v1] soc: samsung: usi: prevent wrong bits inversion during unconfiguring Ivaylo Ivanov
2025-04-14 8:11 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®