* [PATCH] SVM: Fix warnings in svm.h [not found] <tencent_B97FAD99B25D9BCC5AB9EA89BA04061D7B07@qq.com> @ 2023-07-12 13:39 ` huzhi001 2023-07-12 13:59 ` Peter Zijlstra 0 siblings, 1 reply; 3+ messages in thread From: huzhi001 @ 2023-07-12 13:39 UTC (permalink / raw) To: seanjc, pbonzini, tglx, mingo, bp, dave.hansen, x86 Cc: hpa, kvm, linux-kernel The following checkpatch warnings are removed: WARNING: Prefer __packed over __attribute__((__packed__)) Signed-off-by: ZhiHu <huzhi001@208suo.com> --- arch/x86/include/asm/svm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h index e7c7379d6ac7..7ecebccf8a83 100644 --- a/arch/x86/include/asm/svm.h +++ b/arch/x86/include/asm/svm.h @@ -119,7 +119,7 @@ enum { }; -struct __attribute__ ((__packed__)) vmcb_control_area { +struct __packed vmcb_control_area { u32 intercepts[MAX_INTERCEPT]; u32 reserved_1[15 - MAX_INTERCEPT]; u16 pause_filter_thresh; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SVM: Fix warnings in svm.h 2023-07-12 13:39 ` [PATCH] SVM: Fix warnings in svm.h huzhi001 @ 2023-07-12 13:59 ` Peter Zijlstra 2023-07-12 15:05 ` Randy Dunlap 0 siblings, 1 reply; 3+ messages in thread From: Peter Zijlstra @ 2023-07-12 13:59 UTC (permalink / raw) To: huzhi001 Cc: seanjc, pbonzini, tglx, mingo, bp, dave.hansen, x86, hpa, kvm, linux-kernel On Wed, Jul 12, 2023 at 09:39:24PM +0800, huzhi001@208suo.com wrote: > The following checkpatch warnings are removed: > WARNING: Prefer __packed over __attribute__((__packed__)) Can you please stop with these pointless checkpatch things? ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] SVM: Fix warnings in svm.h 2023-07-12 13:59 ` Peter Zijlstra @ 2023-07-12 15:05 ` Randy Dunlap 0 siblings, 0 replies; 3+ messages in thread From: Randy Dunlap @ 2023-07-12 15:05 UTC (permalink / raw) To: Peter Zijlstra, huzhi001 Cc: seanjc, pbonzini, tglx, mingo, bp, dave.hansen, x86, hpa, kvm, linux-kernel On 7/12/23 06:59, Peter Zijlstra wrote: > On Wed, Jul 12, 2023 at 09:39:24PM +0800, huzhi001@208suo.com wrote: >> The following checkpatch warnings are removed: >> WARNING: Prefer __packed over __attribute__((__packed__)) > > Can you please stop with these pointless checkpatch things? We should probably document that checkpatch should usually just be used on patches and not on entire files. -- ~Randy ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-12 15:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_B97FAD99B25D9BCC5AB9EA89BA04061D7B07@qq.com>
2023-07-12 13:39 ` [PATCH] SVM: Fix warnings in svm.h huzhi001
2023-07-12 13:59 ` Peter Zijlstra
2023-07-12 15:05 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®