mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning
@ 2026-09-29 11:11 Peter Griffin
  2026-09-29 15:47 ` Doug Anderson
  2026-09-30  5:30 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 4+ messages in thread
From: Peter Griffin @ 2026-09-29 11:11 UTC (permalink / raw)
  To: André Draszik, Tudor Ambarus, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Douglas Anderson,
	Brian Norris
  Cc: Juan Yescas, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, kernel-team, Peter Griffin

Fix newly introduced DT warnings:
Warning (avoid_unnecessary_addr_size): /soc@0/interrupt-controller@5880000:
unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or
child "reg" or "ranges" property

Fixes: 80f23487d554c7 ("arm64: dts: google: Add initial dts for frankel/blazer/mustang")
Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
---
 arch/arm64/boot/dts/google/lga.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/google/lga.dtsi b/arch/arm64/boot/dts/google/lga.dtsi
index 26a14b3a1b190a..919ee6619d9ee8 100644
--- a/arch/arm64/boot/dts/google/lga.dtsi
+++ b/arch/arm64/boot/dts/google/lga.dtsi
@@ -370,8 +370,7 @@ gic: interrupt-controller@5880000 {
 			reg = <0x0 0x05880000 0x0 0x10000>,
 			      <0x0 0x05900000 0x0 0x200000>;
 
-			#address-cells = <2>;
-			#size-cells = <2>;
+			#address-cells = <0>;
 
 			#interrupt-cells = <4>;
 			interrupt-controller;

---
base-commit: b736258e80ca4c2c465cd4ec6d2bbf780e99ef55
change-id: 20260929-pixel10-initial-dts-fixup-8c21c6951759

Best regards,
-- 
Peter Griffin <peter.griffin@linaro.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning
  2026-09-29 11:11 [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning Peter Griffin
@ 2026-09-29 15:47 ` Doug Anderson
  2026-09-30  5:22   ` Krzysztof Kozlowski
  2026-09-30  5:30 ` Krzysztof Kozlowski
  1 sibling, 1 reply; 4+ messages in thread
From: Doug Anderson @ 2026-09-29 15:47 UTC (permalink / raw)
  To: Peter Griffin
  Cc: André Draszik, Tudor Ambarus, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Brian Norris, Juan Yescas,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	kernel-team

Hi,

On Tue, Sep 29, 2026 at 4:11 AM Peter Griffin <peter.griffin@linaro.org> wrote:
>
> Fix newly introduced DT warnings:
> Warning (avoid_unnecessary_addr_size): /soc@0/interrupt-controller@5880000:
> unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or
> child "reg" or "ranges" property
>
> Fixes: 80f23487d554c7 ("arm64: dts: google: Add initial dts for frankel/blazer/mustang")

Is the above git hash correct? In linuxnext, I see:

54edd8698bb1 arm64: dts: google: Add initial dts for frankel/blazer/mustang

Other than that, this looks fine to me.

Reviewed-by: Douglas Anderson <dianders@chromium.org>

> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
>  arch/arm64/boot/dts/google/lga.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/google/lga.dtsi b/arch/arm64/boot/dts/google/lga.dtsi
> index 26a14b3a1b190a..919ee6619d9ee8 100644
> --- a/arch/arm64/boot/dts/google/lga.dtsi
> +++ b/arch/arm64/boot/dts/google/lga.dtsi
> @@ -370,8 +370,7 @@ gic: interrupt-controller@5880000 {
>                         reg = <0x0 0x05880000 0x0 0x10000>,
>                               <0x0 0x05900000 0x0 0x200000>;
>
> -                       #address-cells = <2>;
> -                       #size-cells = <2>;
> +                       #address-cells = <0>;
>
>                         #interrupt-cells = <4>;
>                         interrupt-controller;

nit: Leaving "#address-cells = <0>;" alone in a section, with blank
lines before and after, looks a little weird, but it's not a major
issue...

-Doug

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning
  2026-09-29 15:47 ` Doug Anderson
@ 2026-09-30  5:22   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-30  5:22 UTC (permalink / raw)
  To: Doug Anderson, Peter Griffin
  Cc: André Draszik, Tudor Ambarus, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Brian Norris, Juan Yescas,
	linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
	kernel-team

On 29/09/2026 17:47, Doug Anderson wrote:
> Hi,
> 
> On Tue, Sep 29, 2026 at 4:11 AM Peter Griffin <peter.griffin@linaro.org> wrote:
>>
>> Fix newly introduced DT warnings:
>> Warning (avoid_unnecessary_addr_size): /soc@0/interrupt-controller@5880000:
>> unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or
>> child "reg" or "ranges" property
>>
>> Fixes: 80f23487d554c7 ("arm64: dts: google: Add initial dts for frankel/blazer/mustang")
> 
> Is the above git hash correct? In linuxnext, I see:

Yeah:

	WARNING: Unknown commit id '80f23487d554c7', maybe rebased or not pulled?

I'll fix both when applied

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning
  2026-09-29 11:11 [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning Peter Griffin
  2026-09-29 15:47 ` Doug Anderson
@ 2026-09-30  5:30 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-30  5:30 UTC (permalink / raw)
  To: André Draszik, Tudor Ambarus, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Douglas Anderson,
	Brian Norris, Peter Griffin
  Cc: Juan Yescas, linux-arm-kernel, linux-samsung-soc, devicetree,
	linux-kernel, kernel-team


On Tue, 29 Sep 2026 11:11:15 +0000, Peter Griffin wrote:
> Fix newly introduced DT warnings:
> Warning (avoid_unnecessary_addr_size): /soc@0/interrupt-controller@5880000:
> unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or
> child "reg" or "ranges" property

Applied, thanks!

[1/1] arm64: dts: google: lga: fixup #size-cells DT warning
      https://git.kernel.org/krzk/linux/c/18686b294c6f6ba778cba66eccf01b9fcdf48988

Best regards,
-- 
Krzysztof Kozlowski <krzk@kernel.org>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-30  5:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-29 11:11 [PATCH] arm64: dts: google: lga: fixup #size-cells DT warning Peter Griffin
2026-09-29 15:47 ` Doug Anderson
2026-09-30  5:22   ` Krzysztof Kozlowski
2026-09-30  5:30 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®