From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Vikash Garodia <vgarodia@codeaurora.org>
Subject: Re: [PATCH v2 27/29] venus: implementing multi-stream support
Date: Tue, 15 May 2018 12:40:24 +0300 [thread overview]
Message-ID: <e59f146d-bcf1-e402-2e82-23802291cf7a@linaro.org> (raw)
In-Reply-To: <3008410e-3311-b836-a6a8-f95f1161a2e9@xs4all.nl>
Hi Hans,
On 05/15/2018 11:17 AM, Hans Verkuil wrote:
> Hi Stanimir,
>
> On 05/15/18 09:58, Stanimir Varbanov wrote:
>> This is implementing a multi-stream decoder support. The multi
>> stream gives an option to use the secondary decoder output
>> with different raw format (or the same in case of crop).
>
> You told me that multi-stream support is currently internal only.
>
> It would be good if you could elaborate a bit about that in this
> commit log and (I think) also add some comments in the code that
> reflect this.
>
> It's also not clear to me how and why this is used in the driver
> if this is just internal. Does it enable a feature you would
> otherwise not be able to use?
>
> I have no complaints about the code, I would just like to see a
> bit more background information in the source and commit log.
Thanks for the fast comments! Sure I will try to document multi-stream
support in the patch description and in the code if it makes sense.
--
regards,
Stan
next prev parent reply other threads:[~2018-05-15 9:40 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 7:58 [PATCH v2 00/29] Venus updates Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 01/29] venus: hfi_msgs: correct pointer increment Stanimir Varbanov
2018-05-18 8:57 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 02/29] venus: hfi: preparation to support venus 4xx Stanimir Varbanov
2018-05-18 9:44 ` Tomasz Figa
2018-05-21 14:25 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 03/29] venus: hfi: update sequence event to handle more properties Stanimir Varbanov
2018-05-18 13:53 ` Tomasz Figa
2018-05-21 14:31 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 04/29] venus: hfi_cmds: add set_properties for 4xx version Stanimir Varbanov
2018-05-18 14:16 ` Tomasz Figa
2018-05-21 14:53 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 05/29] venus: hfi: support session continue " Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 06/29] venus: hfi: handle buffer output2 type as well Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 07/29] venus: hfi_venus: add halt AXI support for Venus 4xx Stanimir Varbanov
2018-05-18 14:23 ` Tomasz Figa
2018-05-21 12:17 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 08/29] venus: hfi_venus: fix suspend function for venus 3xx versions Stanimir Varbanov
2018-05-18 15:14 ` Tomasz Figa
2018-05-21 12:18 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 09/29] venus: hfi_venus: move set of default properties to core init Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 10/29] venus: hfi_venus: add suspend functionality for Venus 4xx Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 11/29] venus: venc,vdec: adds clocks needed for venus 4xx Stanimir Varbanov
2018-05-24 6:11 ` Tomasz Figa
2018-05-28 8:47 ` Stanimir Varbanov
2018-05-31 6:50 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 12/29] venus: add common capability parser Stanimir Varbanov
2018-05-24 14:16 ` Tomasz Figa
2018-05-30 16:21 ` Stanimir Varbanov
2018-05-31 7:06 ` Tomasz Figa
2018-07-02 9:23 ` Tomasz Figa
2018-07-02 9:59 ` Stanimir Varbanov
2018-07-02 10:05 ` Tomasz Figa
2018-07-02 11:00 ` Stanimir Varbanov
2018-07-05 9:45 ` Stanimir Varbanov
2018-07-05 10:14 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 13/29] venus: helpers: make a commmon function for power_enable Stanimir Varbanov
2018-05-31 7:34 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 14/29] venus: core: delete not used flag for buffer mode Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 15/29] venus: helpers: rename a helper function and use buffer mode from caps Stanimir Varbanov
2018-05-31 7:59 ` Tomasz Figa
2018-05-31 8:23 ` Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 16/29] venus: add a helper function to set dynamic buffer mode Stanimir Varbanov
2018-05-31 8:56 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 17/29] venus: add helper function to set actual buffer size Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 18/29] venus: delete no longer used bufmode flag from instance Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 19/29] venus: helpers: add buffer type argument to a helper Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 20/29] venus: helpers: add a new helper to set raw format Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 21/29] venus: helpers,vdec,venc: add helpers to set work mode and core usage Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 22/29] venus: helpers: extend set_num_bufs helper with one more argument Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 23/29] venus: helpers: add a helper to return opb buffer sizes Stanimir Varbanov
2018-05-31 9:20 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 24/29] venus: vdec: get required input buffers as well Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 25/29] venus: vdec: new function for output configuration Stanimir Varbanov
2018-05-31 9:27 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 26/29] venus: move frame size calculations in common place Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 27/29] venus: implementing multi-stream support Stanimir Varbanov
2018-05-15 8:17 ` Hans Verkuil
2018-05-15 9:40 ` Stanimir Varbanov [this message]
2018-05-18 10:00 ` [PATCH v3 " Stanimir Varbanov
2018-05-31 9:51 ` [PATCH v2 " Tomasz Figa
2018-07-02 9:30 ` Tomasz Figa
2018-07-02 12:43 ` Stanimir Varbanov
2018-07-02 12:52 ` Tomasz Figa
2018-05-15 7:58 ` [PATCH v2 28/29] venus: add sdm845 compatible and resource data Stanimir Varbanov
2018-05-15 7:58 ` [PATCH v2 29/29] venus: add HEVC codec support Stanimir Varbanov
2018-05-15 8:19 ` [PATCH v2 00/29] Venus updates Hans Verkuil
2018-05-31 9:55 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e59f146d-bcf1-e402-2e82-23802291cf7a@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®