mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* List of possible duplicated include files in include/
@ 2007-11-04 18:44 Marco Costalba
  2007-11-04 18:48 ` Robert P. J. Day
  0 siblings, 1 reply; 4+ messages in thread
From: Marco Costalba @ 2007-11-04 18:44 UTC (permalink / raw)
  To: linux-kernel

Here the number of false positives is overhelming, but perhaps there
are also _real_ duplicated include somewhere in the bunch:

include/acpi/acpi_bus.h:
#include <linux/device.h>

include/asm-alpha/core_cia.h:
#include <asm/io_trivial.h>

include/asm-arm/atomic.h:
#include <asm/system.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/cs89712.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/clps7111.h>

include/asm-arm/arch-clps711x/hardware.h:
#include <asm/hardware/ep7212.h>

include/asm-ia64/pgtable.h:
#include <asm/processor.h>

include/asm-m32r/m32r.h:
#include <asm/m32700ut/m32700ut_pld.h>

include/asm-mips/bitops.h:
#include <asm-generic/bitops/fls64.h>

include/asm-mips/tx4938/tx4938.h:
#include <asm/byteorder.h>

include/asm-powerpc/io.h:
#include <asm/io-defs.h>

include/asm-x86/elf.h:
#include <asm/processor.h>

include/asm-x86/msr.h:
#include <linux/errno.h>

include/asm-x86/smp_64.h:
#include <asm/thread_info.h>

include/linux/aio.h:
#include <linux/uio.h>

include/linux/aio.h:
#include <linux/aio_abi.h>

include/linux/atalk.h:
#include <asm/byteorder.h>

include/linux/cgroup.h:
#include <linux/cgroup_subsys.h>

include/linux/icmpv6.h:
#include <linux/skbuff.h>

include/linux/igmp.h:
#include <linux/skbuff.h>

include/linux/udp.h:
#include <linux/types.h>

include/net/ieee80211.h:
#include <linux/wireless.h>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: List of possible duplicated include files in include/
  2007-11-04 18:44 List of possible duplicated include files in include/ Marco Costalba
@ 2007-11-04 18:48 ` Robert P. J. Day
  2007-11-04 18:52   ` Marco Costalba
  0 siblings, 1 reply; 4+ messages in thread
From: Robert P. J. Day @ 2007-11-04 18:48 UTC (permalink / raw)
  To: Marco Costalba; +Cc: linux-kernel

On Sun, 4 Nov 2007, Marco Costalba wrote:

> Here the number of false positives is overhelming, but perhaps there
> are also _real_ duplicated include somewhere in the bunch:
>
> include/acpi/acpi_bus.h:
> #include <linux/device.h>

... snip header file output ...

i deliberately left out header files from my script output.  i can
tweak the script and add this to the web page as well.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: List of possible duplicated include files in include/
  2007-11-04 18:48 ` Robert P. J. Day
@ 2007-11-04 18:52   ` Marco Costalba
  2007-11-04 19:01     ` Robert P. J. Day
  0 siblings, 1 reply; 4+ messages in thread
From: Marco Costalba @ 2007-11-04 18:52 UTC (permalink / raw)
  To: Robert P. J. Day; +Cc: linux-kernel

On 11/4/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> On Sun, 4 Nov 2007, Marco Costalba wrote:
>
> > Here the number of false positives is overhelming, but perhaps there
> > are also _real_ duplicated include somewhere in the bunch:
> >
> > include/acpi/acpi_bus.h:
> > #include <linux/device.h>
>
> ... snip header file output ...
>
> i deliberately left out header files from my script output.  i can
> tweak the script and add this to the web page as well.
>

Here the real job is to fliter out false positives more then print out
the list I would say ;-)

Marco

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: List of possible duplicated include files in include/
  2007-11-04 18:52   ` Marco Costalba
@ 2007-11-04 19:01     ` Robert P. J. Day
  0 siblings, 0 replies; 4+ messages in thread
From: Robert P. J. Day @ 2007-11-04 19:01 UTC (permalink / raw)
  To: Marco Costalba; +Cc: linux-kernel

On Sun, 4 Nov 2007, Marco Costalba wrote:

> On 11/4/07, Robert P. J. Day <rpjday@crashcourse.ca> wrote:
> > On Sun, 4 Nov 2007, Marco Costalba wrote:
> >
> > > Here the number of false positives is overhelming, but perhaps
> > > there are also _real_ duplicated include somewhere in the bunch:
> > >
> > > include/acpi/acpi_bus.h:
> > > #include <linux/device.h>
> >
> > ... snip header file output ...
> >
> > i deliberately left out header files from my script output.  i can
> > tweak the script and add this to the web page as well.
> >
>
> Here the real job is to fliter out false positives more then print
> out the list I would say ;-)

  i don't think there are a lot of false positives there and, in any
event, it's a case of diminishing returns -- if you can get most of
what you want with two minutes of quick-and-dirty scripting, there's
not much point in spending another 10 or 15 minutes trying to tidy
things up only a little.

  just my $0.02 canadian, which is finally worth more than $0.02
american.  :-)

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-11-04 19:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-04 18:44 List of possible duplicated include files in include/ Marco Costalba
2007-11-04 18:48 ` Robert P. J. Day
2007-11-04 18:52   ` Marco Costalba
2007-11-04 19:01     ` Robert P. J. Day

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®