From: Luke Jones <luke@ljones.dev>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
tiwai@suse.com, perex@perex.cz
Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
Date: Tue, 11 Oct 2022 10:50:29 +1300 [thread overview]
Message-ID: <e5de59f50c8e4141edc96f882253feb4a12a6536.camel@ljones.dev> (raw)
In-Reply-To: <87zge3etjw.wl-tiwai@suse.de>
On Mon, 2022-10-10 at 14:45 +0200, Takashi Iwai wrote:
> On Mon, 10 Oct 2022 08:57:02 +0200,
> Luke D. Jones wrote:
> >
> > The initial fix for ASUS G533Z was based on faulty information.
> > This
> > fixes the pincfg to values that have been verified with no existing
> > module options or other hacks enabled.
> >
> > Enables headphone jack, and 5.1 surround.
> >
> > Signed-off-by: Luke D. Jones <luke@ljones.dev>
>
> The changes look OK, but the subject line should be rather describing
> what about the patch is about. I corrected the subject and put the
> proper Fixes tag (as well as Cc-to-stable).
>
> Also, the indent level wasn't right, so I corrected it locally, too.
Oh... Sorry about the hassle there, I could have sworn it was correct.
Thanks for accepting regardless :)
>
> thanks,
>
> Takashi
prev parent reply other threads:[~2022-10-10 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 6:57 Luke D. Jones
2022-10-10 12:45 ` Takashi Iwai
2022-10-10 21:50 ` Luke Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5de59f50c8e4141edc96f882253feb4a12a6536.camel@ljones.dev \
--to=luke@ljones.dev \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®