From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>,
christoffer.dall@arm.com, marc.zyngier@arm.com,
peter.maydell@linaro.org, drjones@redhat.com,
james.morse@arm.com, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension()
Date: Tue, 9 Oct 2018 17:34:24 +0100 [thread overview]
Message-ID: <e5e5f84b-4664-7ba0-9462-5b69a987fd9d@arm.com> (raw)
In-Reply-To: <1539002088-21215-2-git-send-email-gengdongjiu@huawei.com>
Hi,
On 08/10/18 13:34, Dongjiu Geng wrote:
> Rename kvm_arch_dev_ioctl_check_extension() to
> kvm_arch_vm_ioctl_check_extension(), because it does
> not have any relationship with device.
>
> Renaming this function can make code readable.
+1. The current name is not really intuitive.
>
> Cc: James Morse <james.morse@arm.com>
> Signed-off-by: Dongjiu Geng <gengdongjiu@huawei.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2018-10-09 16:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 12:34 [PATCH v2 0/2] rename function name and enable 32bit vcpu events Dongjiu Geng
2018-10-08 12:34 ` [PATCH v2 1/2] arm/arm64: KVM: rename function kvm_arch_dev_ioctl_check_extension() Dongjiu Geng
2018-10-09 16:34 ` Suzuki K Poulose [this message]
2018-10-10 2:29 ` gengdongjiu
2018-10-08 12:34 ` [PATCH v2 2/2] arm/arm64: KVM: enable 32 bits kvm vcpu events support Dongjiu Geng
2018-10-09 17:22 ` Suzuki K Poulose
2018-10-10 4:22 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5e5f84b-4664-7ba0-9462-5b69a987fd9d@arm.com \
--to=suzuki.poulose@arm.com \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=gengdongjiu@huawei.com \
--cc=james.morse@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®