From: Joseph Qi <joseph.qi@linux.alibaba.com>
To: Alexey Velichayshiy <a.velichayshiy@ispras.ru>,
akpm <akpm@linux-foundation.org>
Cc: Joel Becker <jlbec@evilplan.org>,
ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org,
lvc-project@linuxtesting.org, Mark Fasheh <mark@fasheh.com>
Subject: Re: [PATCH] ocfs2: remove redundant error code assignment
Date: Mon, 9 Mar 2026 09:10:02 +0800 [thread overview]
Message-ID: <e622f6e5-baa4-4f7b-b35b-c5ad03db903b@linux.alibaba.com> (raw)
In-Reply-To: <20260307234809.88421-1-a.velichayshiy@ispras.ru>
On 3/8/26 7:47 AM, Alexey Velichayshiy wrote:
> Removed the error assignment for variable 'ret' during correct code
> execution. In subsequent execution, variable 'ret' is overwritten.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dlm/dlmmaster.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index eb62724bbe9b..93eff38fdadd 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -930,7 +930,6 @@ struct dlm_lock_resource * dlm_get_lock_resource(struct dlm_ctxt *dlm,
> if (blocked)
> goto wait;
>
> - ret = -EINVAL;
> dlm_node_iter_init(mle->vote_map, &iter);
> while ((nodenum = dlm_node_iter_next(&iter)) >= 0) {
> ret = dlm_do_master_request(res, mle, nodenum);
prev parent reply other threads:[~2026-03-09 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 23:47 Alexey Velichayshiy
2026-03-09 1:10 ` Joseph Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e622f6e5-baa4-4f7b-b35b-c5ad03db903b@linux.alibaba.com \
--to=joseph.qi@linux.alibaba.com \
--cc=a.velichayshiy@ispras.ru \
--cc=akpm@linux-foundation.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mark@fasheh.com \
--cc=ocfs2-devel@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®