* [PATCH] ocfs2: remove redundant error code assignment
@ 2026-03-07 23:47 Alexey Velichayshiy
2026-03-09 1:10 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Velichayshiy @ 2026-03-07 23:47 UTC (permalink / raw)
To: a.velichayshiy, Mark Fasheh
Cc: Joel Becker, Joseph Qi, ocfs2-devel, linux-kernel, lvc-project
Removed the error assignment for variable 'ret' during correct code
execution. In subsequent execution, variable 'ret' is overwritten.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
---
fs/ocfs2/dlm/dlmmaster.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
index eb62724bbe9b..93eff38fdadd 100644
--- a/fs/ocfs2/dlm/dlmmaster.c
+++ b/fs/ocfs2/dlm/dlmmaster.c
@@ -930,7 +930,6 @@ struct dlm_lock_resource * dlm_get_lock_resource(struct dlm_ctxt *dlm,
if (blocked)
goto wait;
- ret = -EINVAL;
dlm_node_iter_init(mle->vote_map, &iter);
while ((nodenum = dlm_node_iter_next(&iter)) >= 0) {
ret = dlm_do_master_request(res, mle, nodenum);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ocfs2: remove redundant error code assignment
2026-03-07 23:47 [PATCH] ocfs2: remove redundant error code assignment Alexey Velichayshiy
@ 2026-03-09 1:10 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2026-03-09 1:10 UTC (permalink / raw)
To: Alexey Velichayshiy, akpm
Cc: Joel Becker, ocfs2-devel, linux-kernel, lvc-project, Mark Fasheh
On 3/8/26 7:47 AM, Alexey Velichayshiy wrote:
> Removed the error assignment for variable 'ret' during correct code
> execution. In subsequent execution, variable 'ret' is overwritten.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
> ---
> fs/ocfs2/dlm/dlmmaster.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index eb62724bbe9b..93eff38fdadd 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -930,7 +930,6 @@ struct dlm_lock_resource * dlm_get_lock_resource(struct dlm_ctxt *dlm,
> if (blocked)
> goto wait;
>
> - ret = -EINVAL;
> dlm_node_iter_init(mle->vote_map, &iter);
> while ((nodenum = dlm_node_iter_next(&iter)) >= 0) {
> ret = dlm_do_master_request(res, mle, nodenum);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-09 1:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-03-07 23:47 [PATCH] ocfs2: remove redundant error code assignment Alexey Velichayshiy
2026-03-09 1:10 ` Joseph Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®