* [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference
@ 2023-10-09 9:04 Ma Ke
2023-10-09 9:13 ` neil.armstrong
2023-10-10 8:37 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Ma Ke @ 2023-10-09 9:04 UTC (permalink / raw)
To: linus.walleij, neil.armstrong, sam, airlied, daniel
Cc: dri-devel, linux-kernel, Ma Ke
In tpg110_get_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_mode_duplicate(). Add a check to avoid npd.
Signed-off-by: Ma Ke <make_ruc2021@163.com>
---
drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
index 845304435e23..f6a212e542cb 100644
--- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c
+++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
@@ -379,6 +379,8 @@ static int tpg110_get_modes(struct drm_panel *panel,
connector->display_info.bus_flags = tpg->panel_mode->bus_flags;
mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode);
+ if (!mode)
+ return -ENOMEM;
drm_mode_set_name(mode);
mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
--
2.37.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference
2023-10-09 9:04 [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Ma Ke
@ 2023-10-09 9:13 ` neil.armstrong
2023-10-10 8:37 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: neil.armstrong @ 2023-10-09 9:13 UTC (permalink / raw)
To: Ma Ke, linus.walleij, sam, airlied, daniel; +Cc: dri-devel, linux-kernel
On 09/10/2023 11:04, Ma Ke wrote:
> In tpg110_get_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). Add a check to avoid npd.
>
> Signed-off-by: Ma Ke <make_ruc2021@163.com>
> ---
> drivers/gpu/drm/panel/panel-tpo-tpg110.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-tpo-tpg110.c b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> index 845304435e23..f6a212e542cb 100644
> --- a/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> +++ b/drivers/gpu/drm/panel/panel-tpo-tpg110.c
> @@ -379,6 +379,8 @@ static int tpg110_get_modes(struct drm_panel *panel,
> connector->display_info.bus_flags = tpg->panel_mode->bus_flags;
>
> mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode);
> + if (!mode)
> + return -ENOMEM;
> drm_mode_set_name(mode);
> mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference
2023-10-09 9:04 [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Ma Ke
2023-10-09 9:13 ` neil.armstrong
@ 2023-10-10 8:37 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-10-10 8:37 UTC (permalink / raw)
To: linus.walleij, sam, airlied, daniel, Ma Ke; +Cc: dri-devel, linux-kernel
Hi,
On Mon, 09 Oct 2023 17:04:46 +0800, Ma Ke wrote:
> In tpg110_get_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a NULL pointer dereference on
> failure of drm_mode_duplicate(). Add a check to avoid npd.
>
>
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-next)
[1/1] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=f22def5970c423ea7f87d5247bd0ef91416b0658
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-10 8:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-09 9:04 [PATCH v2] drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference Ma Ke
2023-10-09 9:13 ` neil.armstrong
2023-10-10 8:37 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®