mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org,
	x86@kernel.org, boris.ostrovsky@oracle.com, hpa@zytor.com,
	tglx@linutronix.de, mingo@redhat.com
Subject: Re: [PATCH] x86/amd: don't set X86_BUG_SYSRET_SS_ATTRS if forced to zero
Date: Thu, 27 Apr 2017 06:44:02 +0200	[thread overview]
Message-ID: <e639eaed-aabf-c4bf-f346-1a0ae41d1db4@suse.com> (raw)
In-Reply-To: <20170426220448.sjsg4f7odacb2uz3@pd.tnic>

On 27/04/17 00:04, Borislav Petkov wrote:
> On Wed, Apr 26, 2017 at 08:24:12PM +0200, Juergen Gross wrote:
>> I'm not feeling strong about it. So if you want to test for
>> X86_FEATURE_XENPV to avoid setting X86_BUG_SYSRET_SS_ATTRS I'm fine
>> with it.
>>
>> Will send V2 with that change.
> 
> And remove the corresponding
> 
> 	clear_cpu_bug(c, X86_BUG_SYSRET_SS_ATTRS);
> 
> in xen_set_cpu_features().

Okay, you are right, we can omit this one now.

> So that we can set it once, only on !XENPV feature set.
> 
> /me looks again at the code...
> 
> Gah, except that we do
> 
> 	set_cpu_cap(c, X86_FEATURE_XENPV);
> 
> and that runs as part of init_hypervisor() and it runs *after* c_init().

No, this is called by xen_start_kernel(), long before c_init().

> So, back to square one. :-\
> 
> So lemme try to explain again what I mean:
> 
> I'd like to have a generic way of detecting whether I'm running as a xen
> guest at ->c_init() time and depending on the result of that detection,
> to set X86_BUG_SYSRET_SS_ATTRS or not set it.
> 
> Does that make more sense?

This does make sense and it is working, as Sander could confirm.


Juergen

      reply	other threads:[~2017-04-27  4:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-25 18:00 Juergen Gross
2017-04-25 18:24 ` Borislav Petkov
2017-04-25 18:34   ` Juergen Gross
2017-04-25 19:18     ` Borislav Petkov
2017-04-25 20:17       ` [Xen-devel] " Andrew Cooper
2017-04-25 20:27         ` Borislav Petkov
2017-04-26  4:45       ` Juergen Gross
2017-04-26  6:35         ` Borislav Petkov
2017-04-26 18:24           ` Juergen Gross
2017-04-26 22:04             ` Borislav Petkov
2017-04-27  4:44               ` Juergen Gross [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e639eaed-aabf-c4bf-f346-1a0ae41d1db4@suse.com \
    --to=jgross@suse.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®