[PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Qianhui Xu]

Add DT binding for the Will Semiconductor WL2868C camera PMIC with
seven programmable LDOs.

Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
 MAINTAINERS                                        |    6 ++
 .../bindings/regulator/willsemi,wl2868c.yaml       |   67 ++++++++++++++++++++
 2 files changed, 73 insertions(+)
---
 .../bindings/regulator/willsemi,wl2868c.yaml  | 67 +++++++++++++++++++
 MAINTAINERS                                   |  6 ++
 2 files changed, 73 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml

diff --git a/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml b/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
new file mode 100644
index 000000000..8dc729c90
--- /dev/null
+++ b/Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
@@ -0,0 +1,67 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/regulator/willsemi,wl2868c.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Will Semiconductor WL2868C camera power management IC
+
+maintainers:
+  - Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+
+description:
+  Seven programmable LDOs with separate inputs for LDO1/2, LDO3/4,
+  LDO5, LDO6 and LDO7. LDO1/2 support 0.496 to 1.512 V and LDO3-7
+  support 1.504 to 3.544 V, in 8 mV steps.
+
+properties:
+  compatible:
+    const: willsemi,wl2868c
+
+  reg:
+    maxItems: 1
+
+  reset-gpios:
+    maxItems: 1
+    description: Active-low RST_N input.
+
+  vin12-supply: true
+  vin34-supply: true
+  vin5-supply: true
+  vin6-supply: true
+  vin7-supply: true
+
+  regulators:
+    type: object
+    additionalProperties: false
+    patternProperties:
+      "^ldo[1-7]$":
+        type: object
+        $ref: regulator.yaml#
+        unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - regulators
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        pmic@2f {
+            compatible = "willsemi,wl2868c";
+            reg = <0x2f>;
+
+            regulators {
+                ldo1 {
+                    regulator-min-microvolt = <1200000>;
+                    regulator-max-microvolt = <1200000>;
+                };
+            };
+        };
+    };
diff --git a/MAINTAINERS b/MAINTAINERS
index 620fdef73..f598dcf4e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -29285,6 +29285,12 @@ F:	include/linux/regulator/
 F:	include/uapi/regulator/
 K:	regulator_get_optional
 
+WILLSEMI WL2868C CAMERA PMIC DRIVER
+M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
+L:	linux-media@vger.kernel.org
+S:	Maintained
+F:	Documentation/devicetree/bindings/regulator/willsemi,wl2868c.yaml
+
 VOLTAGE AND CURRENT REGULATOR IRQ HELPERS
 R:	Matti Vaittinen <mazziesaccount@gmail.com>
 F:	drivers/regulator/irq_helpers.c
-- 
2.53.0

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Mark Brown]

> Add DT binding for the Will Semiconductor WL2868C camera PMIC with
> seven programmable LDOs.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

> @@ -29303,6 +29303,12 @@ F:	include/linux/regulator/
>  F:	include/uapi/regulator/
>  K:	regulator_get_optional
>  
> +WILLSEMI WL2868C CAMERA PMIC DRIVER

Please keep the file sorted.

Seems a bit premature to say we've got a driver when this is just the
binding!

> +M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> +L:	linux-media@vger.kernel.org

A bit odd to have linux-media, I guess that's because of the systems tis
is usually used on?

-- 
Mark Brown <broonie@kernel.org>

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Qianhui Xu]

On Tue, Oct 27, 2026 at 05:58:24PM +0000, Mark Brown wrote:
> Please submit patches using subject lines reflecting the style for the
> subsystem, this makes it easier for people to identify relevant patches.

Changed in v2 to:

  regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC

which is the shape the regulator tree is using (e.g. "regulator:
dt-bindings: ti,lp872x: Document input supplies", "regulator:
dt-bindings: sy8827n: support standard properties").  The v1 prefix was
copied from the media-side bindings I was preparing in the same batch,
which was my mistake.

> > +WILLSEMI WL2868C CAMERA PMIC DRIVER
>
> Please keep the file sorted.

Moved.  It was sitting after "VOLTAGE AND CURRENT REGULATOR FRAMEWORK",
which is the V section, while the entry name starts with W.  It is now
between "WIIMOTE HID DRIVER" and "WILOCITY WIL6210 WIRELESS DRIVER".

> Seems a bit premature to say we've got a driver when this is just the
> binding!

Agreed, the "DRIVER" suffix is dropped: the section is now "WILLSEMI
WL2868C CAMERA PMIC".  The regulator driver is a separate patch that I
will send to this list; if a driver section is wanted at that point it
should come with that patch.

> > +M:	Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> > +L:	linux-media@vger.kernel.org
>
> A bit odd to have linux-media, I guess that's because of the systems tis
> is usually used on?

Yes, that was the reasoning - it is a camera PMIC - but it is the wrong
list to send it to.  The device registers as a regulator and is collected
by the regulator tree, so v2 uses L: linux-kernel@vger.kernel.org like the
other single-file regulator bindings (maxim,max20086.yaml,
maxim,max77838.yaml).  linux-media is dropped.

There is one more thing you may want to know about v2: Krzysztof pointed
out the v1 mail was a broken patch.  The diffstat had been typed into the
commit message, so the mail had two of them.  v2 is a real commit in a
pristine 7.3-rc7 worktree exported with git format-patch.  I have also
added the consumer information to the commit message, since "why do we
want this binding" was the other open question: it is the camera PMIC on
the Lenovo Legion Tab (TB322FC, SM8750), feeding the DVDD/AVDD/DOVDD rails
of both camera sensors.

Qianhui

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Krzysztof Kozlowski]

On 28/10/2026 13:04, Qianhui Xu wrote:
> On Tue, Oct 27, 2026 at 05:58:24PM +0000, Mark Brown wrote:
>> Please submit patches using subject lines reflecting the style for the
>> subsystem, this makes it easier for people to identify relevant patches.
> 
> Changed in v2 to:
> 
>   regulator: dt-bindings: willsemi,wl2868c: add the WL2868C camera PMIC
> 
> which is the shape the regulator tree is using (e.g. "regulator:
> dt-bindings: ti,lp872x: Document input supplies", "regulator:
> dt-bindings: sy8827n: support standard properties").  The v1 prefix was
> copied from the media-side bindings I was preparing in the same batch,
> which was my mistake.
> 
>>> +WILLSEMI WL2868C CAMERA PMIC DRIVER
>>
>> Please keep the file sorted.
> 
> Moved.  It was sitting after "VOLTAGE AND CURRENT REGULATOR FRAMEWORK",
> which is the V section, while the entry name starts with W.  It is now
> between "WIIMOTE HID DRIVER" and "WILOCITY WIL6210 WIRELESS DRIVER".
> 

That's LLM output. Why do you paste it?

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Krzysztof Kozlowski]

On 27/10/2026 06:10, Qianhui Xu wrote:
> Add DT binding for the Will Semiconductor WL2868C camera PMIC with
> seven programmable LDOs.
> 
> Signed-off-by: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
>  MAINTAINERS                                        |    6 ++

Looks like broken patch. Please use git or b4 to generate patches.



>  .../bindings/regulator/willsemi,wl2868c.yaml       |   67 ++++++++++++++++++++
>  2 files changed, 73 insertions(+)
> ---
>  .../bindings/regulator/willsemi,wl2868c.yaml  | 67 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 73 insertions(+)

Anyway, where is any user of this? Why do we want this binding?
Best regards,
Krzysztof

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Qianhui Xu]

On Tue, Oct 27, 2026 at 07:04:55PM +0100, Krzysztof Kozlowski wrote:
> Looks like broken patch. Please use git or b4 to generate patches.

You are right, and I found what happened.  The patch was not produced by
git format-patch on a commit: the diffstat was typed into the commit
message body, so the mail carried two of them - one pasted directly under
the Signed-off-by (no blank line), and one appended by format-patch.  I
reproduced it locally by git am'ing the sent patch onto pristine 7.3-rc7
and reading back the resulting commit message, which contains the pasted
stat.

The v2 I am sending right after this mail is a real commit in a pristine
7.3-rc7 worktree exported with git format-patch, so the body has exactly
one diffstat.  The diff itself was never the problem - git apply --check
passed all along, which is why my local checkpatch run did not catch it.

> Anyway, where is any user of this? Why do we want this binding?

The user is the camera stack on the Lenovo Legion Tab (TB322FC), an SM8750
tablet.  The WL2868C sits on i2c10 at 0x2f and feeds both camera sensors:

  - rear sensor:  dovdd <- ldo7, dvdd <- ldo1, avdd <- ldo4
  - front sensor: dovdd <- ldo7, dvdd <- ldo2, avdd <- ldo3

and ldo5 supplies the VCM actuator.  These are the *-supply references
in the board DTS; without a binding for the PMIC they dangle, so the
camera nodes cannot be described at all.  The regulator driver itself is a
separate patch I will send to the regulator list - I held it back so this
binding could be reviewed on its own, but that left the binding looking
like it had no consumer, which is a fair objection and I have now put the
consumer information into the commit message.

Sorry for the noise.

Qianhui

Re: [PATCH] dt-bindings: regulator: add Will Semiconductor WL2868C PMIC

[Krzysztof Kozlowski]

On 28/10/2026 13:04, Qianhui Xu wrote:
> On Tue, Oct 27, 2026 at 07:04:55PM +0100, Krzysztof Kozlowski wrote:
>> Looks like broken patch. Please use git or b4 to generate patches.
> 
> You are right, and I found what happened.  The patch was not produced by
> git format-patch on a commit: the diffstat was typed into the commit
> message body, so the mail carried two of them - one pasted directly under
> the Signed-off-by (no blank line), and one appended by format-patch.  I
> reproduced it locally by git am'ing the sent patch onto pristine 7.3-rc7
> and reading back the resulting commit message, which contains the pasted
> stat.
> 
> The v2 I am sending right after this mail is a real commit in a pristine
> 7.3-rc7 worktree exported with git format-patch, so the body has exactly
> one diffstat.  The diff itself was never the problem - git apply --check
> passed all along, which is why my local checkpatch run did not catch it.
> 
>> Anyway, where is any user of this? Why do we want this binding?
> 
> The user is the camera stack on the Lenovo Legion Tab (TB322FC), an SM8750
> tablet.  The WL2868C sits on i2c10 at 0x2f and feeds both camera sensors:
> 
>   - rear sensor:  dovdd <- ldo7, dvdd <- ldo1, avdd <- ldo4
>   - front sensor: dovdd <- ldo7, dvdd <- ldo2, avdd <- ldo3
> 
> and ldo5 supplies the VCM actuator.  These are the *-supply references
> in the board DTS; without a binding for the PMIC they dangle, so the
> camera nodes cannot be described at all.  The regulator driver itself is a
> separate patch I will send to the regulator list - I held it back so this
> binding could be reviewed on its own, but that left the binding looking
> like it had no consumer, which is a fair objection and I have now put the
> consumer information into the commit message.
> 


Reply looks like it was generated by a poor LLM or poorly managed one.

Such poor LLM produces text difficult to read and understand, very
unnatural for upstream kernel discussion. Discussing with such LLM is an
excessive use of maintainer's resources. It also brings doubts that
actual human is involved in discussion, which, if that is true, would be
a total waste of time.

Best regards,
Krzysztof