[PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

[PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

[Prashant Malani]

Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
subdevice on non-ACPI platforms.

This driver allows other cros-ec devices to receive PD event
notifications from the Chrome OS Embedded Controller (EC) via a
notification chain.

Signed-off-by: Prashant Malani <pmalani@chromium.org>
---

Changes in v2:
- Removed auto-generated Change-Id.

 drivers/mfd/cros_ec_dev.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
index c4b977a5dd966..1dde480f35b93 100644
--- a/drivers/mfd/cros_ec_dev.c
+++ b/drivers/mfd/cros_ec_dev.c
@@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
 static const struct mfd_cell cros_usbpd_charger_cells[] = {
 	{ .name = "cros-usbpd-charger", },
 	{ .name = "cros-usbpd-logger", },
+#ifndef CONFIG_ACPI
+	{ .name = "cros-usbpd-notify", },
+#endif
 };
 
 static const struct cros_feature_to_cells cros_subdevices[] = {
-- 
2.24.1.735.g03f4e72817-goog

Re: [PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

[Enric Balletbo i Serra]

Hi Prashant,

Please try to maintain versions and changelog consistently. I.e I see v2 here
but I guess you only send this patch not the full series, also I see that you
send v3 before this?

In general you should send the full series on every version and maintain a full
changelog.

I'd like to see v4 including all the series so it's clear from were we pick up
the patches.

On 20/12/19 1:49, Prashant Malani wrote:
> Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> subdevice on non-ACPI platforms.
> 
> This driver allows other cros-ec devices to receive PD event
> notifications from the Chrome OS Embedded Controller (EC) via a
> notification chain.
> 
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

For v4 you can include:

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Thanks,
 Enric

> ---
> 
> Changes in v2:
> - Removed auto-generated Change-Id.
> 
>  drivers/mfd/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index c4b977a5dd966..1dde480f35b93 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
>  	{ .name = "cros-usbpd-charger", },
>  	{ .name = "cros-usbpd-logger", },
> +#ifndef CONFIG_ACPI
> +	{ .name = "cros-usbpd-notify", },
> +#endif
>  };
>  
>  static const struct cros_feature_to_cells cros_subdevices[] = {
> 

Re: [PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger

[Prashant Malani]

On Fri, Dec 20, 2019 at 12:52 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Prashant,
>
> Please try to maintain versions and changelog consistently. I.e I see v2 here
> but I guess you only send this patch not the full series, also I see that you
> send v3 before this?
>
> In general you should send the full series on every version and maintain a full
> changelog.
>
> I'd like to see v4 including all the series so it's clear from were we pick up
> the patches.
>
> On 20/12/19 1:49, Prashant Malani wrote:
> > Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> > subdevice on non-ACPI platforms.
> >
> > This driver allows other cros-ec devices to receive PD event
> > notifications from the Chrome OS Embedded Controller (EC) via a
> > notification chain.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
>
> For v4 you can include:
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Since the v4 of this patch involves a substantial difference from the
previous version, I determined not to auto-add the Acked-by. My
apologies if you reckon I should've added it anyway.
>
> Thanks,
>  Enric
>
> > ---
> >
> > Changes in v2:
> > - Removed auto-generated Change-Id.
> >
> >  drivers/mfd/cros_ec_dev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index c4b977a5dd966..1dde480f35b93 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
> >  static const struct mfd_cell cros_usbpd_charger_cells[] = {
> >       { .name = "cros-usbpd-charger", },
> >       { .name = "cros-usbpd-logger", },
> > +#ifndef CONFIG_ACPI
> > +     { .name = "cros-usbpd-notify", },
> > +#endif
> >  };
> >
> >  static const struct cros_feature_to_cells cros_subdevices[] = {
> >