From: Moteen Shah <m-shah@ti.com>
To: Judith Mendez <jm@ti.com>, Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>
Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls
Date: Fri, 20 Feb 2026 14:27:41 +0530 [thread overview]
Message-ID: <e651f6a9-5867-4326-bd98-10a37bf26019@ti.com> (raw)
In-Reply-To: <20260212184246.2316659-3-jm@ti.com>
Hey Judith,
On 13/02/26 00:12, Judith Mendez wrote:
> AM62L EVM has external pullups on MMC0 CMD and D0 pins [0]. Remove
> internal pullups considering:
> - having both internal and external pullups reduces the total pull-up
> resistance < 47K resulting in a value below the spec recommended 50K ohms
> - having both pullups results in unnecessary power consumption
>
> Fixes: 00fb4c73b67d ("arm64: dts: ti: k3-am62l: add initial reference board file")
> [0] https://www.ti.com/lit/zip/SPRCAL6
> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62l3-evm.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> index cae04cce33736..5085cd255fcd5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am62l3-evm.dts
> @@ -253,9 +253,9 @@ AM62LX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D8) I2C2_SDA */
>
> mmc0_pins_default: mmc0-default-pins {
> pinctrl-single,pins = <
> - AM62LX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (D2) MMC0_CMD */
> + AM62LX_IOPAD(0x0214, PIN_INPUT, 0) /* (D2) MMC0_CMD */
> AM62LX_IOPAD(0x020c, PIN_OUTPUT, 0) /* (B2) MMC0_CLK */
> - AM62LX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (D3) MMC0_DAT0 */
> + AM62LX_IOPAD(0x0208, PIN_INPUT, 0) /* (D3) MMC0_DAT0 */
> AM62LX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (D4) MMC0_DAT1 */
> AM62LX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (C1) MMC0_DAT2 */
> AM62LX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (C2) MMC0_DAT3 */
Wont the change result in mismatched pullup resistance and will the
mismatch between D0 and D1-D3 won't cause potential timing issues for
modes with tighter timing requirements?
Regards,
Moteen
next prev parent reply other threads:[~2026-02-20 8:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-12 18:42 [PATCH 0/4] Fix MMC pin pull configurations Judith Mendez
2026-02-12 18:42 ` [PATCH 1/4] arm64: dts: ti: k3-am62p5-sk: Disable MMC1 internal pulls on data lines Judith Mendez
2026-02-12 18:42 ` [PATCH 2/4] arm64: dts: ti: k3-am62l-evm: Disable MMC0 internal pulls Judith Mendez
2026-02-20 8:57 ` Moteen Shah [this message]
2026-02-23 20:15 ` Judith Mendez
2026-02-12 18:42 ` [PATCH 3/4] arm64: dts: ti: k3-am62l-evm: Disable MMC1 internal pulls on data pins Judith Mendez
2026-02-12 18:42 ` [PATCH 4/4] arm64: dts: ti: k3-am62-lp-sk: Enable internal pulls for MMC0 " Judith Mendez
2026-02-20 9:00 ` Moteen Shah
2026-02-20 8:49 ` [PATCH 0/4] Fix MMC pin pull configurations Moteen Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e651f6a9-5867-4326-bd98-10a37bf26019@ti.com \
--to=m-shah@ti.com \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jm@ti.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®