From: Hannes Reinecke <hare@suse.de>
To: Lee Duncan <leeman.duncan@gmail.com>, linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Lee Duncan <lduncan@suse.com>
Subject: Re: [PATCH 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"
Date: Tue, 6 Feb 2024 10:14:11 +0900 [thread overview]
Message-ID: <e671344b-259e-44c8-9197-d5b3a76c2459@suse.de> (raw)
In-Reply-To: <83489c47c973bdf7c47e4bf3acbc57dfca1e5dd7.1706632031.git.lduncan@suse.com>
On 1/31/24 00:42, Lee Duncan wrote:
> From: Lee Duncan <lduncan@suse.com>
>
> This reverts commit 1a1975551943f681772720f639ff42fbaa746212
>
> This commit causes interrupts to be lost for FCoE devices,
> since it changed sping locks from "bh" to "irqsave".
>
> Instead, a work queue should be used, and will be addressed
> in a separate patch.
>
> Fixes: 1a1975551943f681772720f639ff42fbaa746212
> Signed-off-by: Lee Duncan <lduncan@suse.com>
> ---
> drivers/scsi/fcoe/fcoe_ctlr.c | 20 ++++++++------------
> 1 file changed, 8 insertions(+), 12 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich
next prev parent reply other threads:[~2024-02-06 1:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 16:42 [PATCH 0/2] Ensure FCoE target interrupts work Lee Duncan
2024-01-30 16:42 ` [PATCH 1/2] Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock" Lee Duncan
2024-02-06 1:14 ` Hannes Reinecke [this message]
2024-01-30 16:42 ` [PATCH 2/2] fnic: move fnic_fnic_flush_tx() to a work queue Lee Duncan
2024-01-31 11:50 ` kernel test robot
2024-02-06 1:23 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e671344b-259e-44c8-9197-d5b3a76c2459@suse.de \
--to=hare@suse.de \
--cc=lduncan@suse.com \
--cc=leeman.duncan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®