mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] crypto:space required before the open brace '{'
       [not found] <tencent_0DF4FE9D6A06DCE7069F936CA2A8154EC105@qq.com>
@ 2023-07-13  8:59 ` chenqingyun001
  2023-07-13  9:42   ` Ard Biesheuvel
  0 siblings, 1 reply; 2+ messages in thread
From: chenqingyun001 @ 2023-07-13  8:59 UTC (permalink / raw)
  To: herbert, davem, catalin.marinas, will; +Cc: linux-crypto, linux-kernel

Maintain code readability and style consistency

Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com>
---
  arch/arm64/crypto/ghash-ce-glue.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/crypto/ghash-ce-glue.c 
b/arch/arm64/crypto/ghash-ce-glue.c
index 97331b454ea8..cb1cd161c022 100644
--- a/arch/arm64/crypto/ghash-ce-glue.c
+++ b/arch/arm64/crypto/ghash-ce-glue.c
@@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm, 
const u8 *inkey,
      if (ret)
          return -EINVAL;

-    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
+    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});

      /* needed for the fallback */
      memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] crypto:space required before the open brace '{'
  2023-07-13  8:59 ` [PATCH] crypto:space required before the open brace '{' chenqingyun001
@ 2023-07-13  9:42   ` Ard Biesheuvel
  0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2023-07-13  9:42 UTC (permalink / raw)
  To: chenqingyun001
  Cc: herbert, davem, catalin.marinas, will, linux-crypto, linux-kernel

On Thu, 13 Jul 2023 at 10:59, <chenqingyun001@208suo.com> wrote:
>
> Maintain code readability and style consistency
>
> Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com>

NAK

This is a cast operation, which doesn't require a trailing space.

If the tool you are using misidentifies this, please fix the tool instead.


> ---
>   arch/arm64/crypto/ghash-ce-glue.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/crypto/ghash-ce-glue.c
> b/arch/arm64/crypto/ghash-ce-glue.c
> index 97331b454ea8..cb1cd161c022 100644
> --- a/arch/arm64/crypto/ghash-ce-glue.c
> +++ b/arch/arm64/crypto/ghash-ce-glue.c
> @@ -241,7 +241,7 @@ static int gcm_aes_setkey(struct crypto_aead *tfm,
> const u8 *inkey,
>       if (ret)
>           return -EINVAL;
>
> -    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]){});
> +    aes_encrypt(&ctx->aes_key, key, (u8[AES_BLOCK_SIZE]) {});
>
>       /* needed for the fallback */
>       memcpy(&ctx->ghash_key.k, key, GHASH_BLOCK_SIZE);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-13  9:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <tencent_0DF4FE9D6A06DCE7069F936CA2A8154EC105@qq.com>
2023-07-13  8:59 ` [PATCH] crypto:space required before the open brace '{' chenqingyun001
2023-07-13  9:42   ` Ard Biesheuvel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®