From: Wan ZongShun <mcuos.com@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4]ARM: NUC900: enable uart support for nuc932
Date: Fri, 4 Dec 2009 22:20:51 +0800 [thread overview]
Message-ID: <e68bb3470912040620v7d6d9c67s176f6e8aef8a3638@mail.gmail.com> (raw)
In-Reply-To: <20091203194132.GA27666@n2100.arm.linux.org.uk>
2009/12/4 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Wed, Dec 02, 2009 at 09:58:25PM +0800, Wan ZongShun wrote:
>> diff --git a/arch/arm/mach-w90x900/clock.h b/arch/arm/mach-w90x900/clock.h
>> index b9ea2e6..2a2a54a 100644
>> --- a/arch/arm/mach-w90x900/clock.h
>> +++ b/arch/arm/mach-w90x900/clock.h
>> @@ -14,8 +14,10 @@
>>
>> #ifndef CONFIG_CPU_NUC932
>> #define EXTCLK 15000000
>> +#define UARTCLK 11313600
>> #else
>> #define EXTCLK 27000000
>> +#define UARTCLK 57139200
>> #endif
>
> As far as I can see, these are the only thing which prevent a single
> kernel being built to cover both NUC900 and NUC932.
>
> Can we make their selection something which is done at runtime instead
> of compile time? This comments goes for patch 5837/1 in the patch
> system as well.
>
Do you mean that I should use following form instead?
"if (machine_is_nuc932evb())"
code....
--
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2009-12-04 14:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 13:58 Wan ZongShun
2009-12-03 19:41 ` Russell King - ARM Linux
2009-12-04 14:20 ` Wan ZongShun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e68bb3470912040620v7d6d9c67s176f6e8aef8a3638@mail.gmail.com \
--to=mcuos.com@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome