mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4]ARM: NUC900: enable uart support for nuc932
Date: Thu, 3 Dec 2009 19:41:32 +0000	[thread overview]
Message-ID: <20091203194132.GA27666@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4B167281.1090708@gmail.com>

On Wed, Dec 02, 2009 at 09:58:25PM +0800, Wan ZongShun wrote:
> diff --git a/arch/arm/mach-w90x900/clock.h b/arch/arm/mach-w90x900/clock.h
> index b9ea2e6..2a2a54a 100644
> --- a/arch/arm/mach-w90x900/clock.h
> +++ b/arch/arm/mach-w90x900/clock.h
> @@ -14,8 +14,10 @@
>  
>  #ifndef CONFIG_CPU_NUC932
>  #define EXTCLK	15000000
> +#define UARTCLK	11313600
>  #else
>  #define EXTCLK	27000000
> +#define UARTCLK	57139200
>  #endif

As far as I can see, these are the only thing which prevent a single
kernel being built to cover both NUC900 and NUC932.

Can we make their selection something which is done at runtime instead
of compile time?  This comments goes for patch 5837/1 in the patch
system as well.

  reply	other threads:[~2009-12-03 19:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 13:58 Wan ZongShun
2009-12-03 19:41 ` Russell King - ARM Linux [this message]
2009-12-04 14:20   ` Wan ZongShun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091203194132.GA27666@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcuos.com@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®