From: Andrew Davis <afd@ti.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Sebastian Reichel <sre@kernel.org>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] power: reset: xgene-reboot: Fix a NULL vs IS_ERR() test
Date: Tue, 20 Feb 2024 07:55:35 -0600 [thread overview]
Message-ID: <e69f523e-8d58-4a4f-af28-7238e818eac1@ti.com> (raw)
In-Reply-To: <fe1b90d0-7234-4e03-accc-69a119f6a7eb@moroto.mountain>
On 2/20/24 3:02 AM, Dan Carpenter wrote:
> The devm_platform_ioremap_resource() function returns error points. It
> never returns NULL. Update the check accordingly.
>
> Fixes: 7ddfd33c6ee5 ("power: reset: xgene-reboot: Use devm_platform_ioremap_resource() helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
Acked-by: Andrew Davis <afd@ti.com>
> drivers/power/reset/xgene-reboot.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/xgene-reboot.c b/drivers/power/reset/xgene-reboot.c
> index 867162dfe7ea..b5eee19bac42 100644
> --- a/drivers/power/reset/xgene-reboot.c
> +++ b/drivers/power/reset/xgene-reboot.c
> @@ -51,9 +51,9 @@ static int xgene_reboot_probe(struct platform_device *pdev)
> return -ENOMEM;
>
> ctx->csr = devm_platform_ioremap_resource(pdev, 0);
> - if (!ctx->csr) {
> + if (IS_ERR(ctx->csr)) {
> dev_err(dev, "can not map resource\n");
> - return -ENODEV;
> + return PTR_ERR(ctx->csr);
> }
>
> if (of_property_read_u32(dev->of_node, "mask", &ctx->mask))
next prev parent reply other threads:[~2024-02-20 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 9:02 Dan Carpenter
2024-02-20 13:55 ` Andrew Davis [this message]
2024-02-21 23:05 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e69f523e-8d58-4a4f-af28-7238e818eac1@ti.com \
--to=afd@ti.com \
--cc=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®