From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jie Gan <quic_jiegan@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] arm64: dts: qcom: qcs8300: Add coresight nodes
Date: Mon, 23 Dec 2024 13:09:01 +0100 [thread overview]
Message-ID: <e6b3e570-81ff-459c-8a5f-55014d22c6d8@oss.qualcomm.com> (raw)
In-Reply-To: <20241219024208.3462358-1-quic_jiegan@quicinc.com>
On 19.12.2024 3:42 AM, Jie Gan wrote:
> Add following coresight components for QCS8300 platform.
> It includes CTI, dummy sink, dynamic Funnel, Replicator, STM,
> TPDM, TPDA and TMC ETF.
>
> Signed-off-by: Jie Gan <quic_jiegan@quicinc.com>
> ---
So I took a look at a bunch of reg values in this patch and the
computer tells me they're bound to names similar to the compatible
strings (good).
This patch is unreviewably long, but at the same time it's made of
very repetitive bits. I'm trusting you that you tested out all of
these coresight components.
I scrolled through a chunk of this, and syntactically it looks good,
Rob's bot doesn't seem to complain either, so FWIW:
Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2024-12-23 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 2:42 Jie Gan
2024-12-23 12:09 ` Konrad Dybcio [this message]
2024-12-26 22:38 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6b3e570-81ff-459c-8a5f-55014d22c6d8@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jiegan@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®