From: John Garry <john.garry@huawei.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "xuwei (O)" <xuwei5@hisilicon.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linuxarm <linuxarm@huawei.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SoC Team <soc@kernel.org>,
Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full()
Date: Fri, 2 Sep 2022 07:46:33 +0100 [thread overview]
Message-ID: <e6ded6f5-7132-e6e3-1f91-12deeb3b12ff@huawei.com> (raw)
In-Reply-To: <CAHp75Vcg79sZjv24DD3ZhYf9aC-zoEZ59gfagS1Jw1-GYhpQug@mail.gmail.com>
On 01/09/2022 18:47, Andy Shevchenko wrote:
>> + .name = "hisi-lpc-ipmi",
>> + .id = PLATFORM_DEVID_AUTO,
>> +
>> + .res = res,
>> + .num_res = num_res,
>> + },
> ...here and in the other cases you have a lot of blank lines, can we
> just get rid of them?
ok
>
>> + },
>> },
>> /* 8250-compatible uart */
>> {
>> .hid = "HISI1031",
>> - .name = "serial8250",
>> - .pdata = (struct plat_serial8250_port []) {
>> + .pdevinfo = (struct platform_device_info []) {
>> {
>> - .iobase = res->start,
>> - .uartclk = 1843200,
>> - .iotype = UPIO_PORT,
>> - .flags = UPF_BOOT_AUTOCONF,
>> + .parent = hostdev,
>> + .fwnode = acpi_fwnode_handle(child),
>> +
>> + .name = "serial8250",
>> + .id = PLATFORM_DEVID_AUTO,
>> +
>> + .res = res,
>> + .num_res = num_res,
>> +
>> + .data = (struct plat_serial8250_port []) {
>> + {
>> + .iobase = res->start,
>> + .uartclk = 1843200,
>> + .iotype = UPIO_PORT,
>> + .flags = UPF_BOOT_AUTOCONF,
>> + },
>> + {}
>> + },
>> + .size_data = 2 *
>> + sizeof(struct plat_serial8250_port),
> I believe this can be one line.
I think so, as we're exceeding 80 char width anyway.
>
>> },
Thanks,
John
prev parent reply other threads:[~2022-09-02 6:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-01 11:14 [PATCH 0/5] Misc hisi_lpc changes John Garry
2022-09-01 11:14 ` [PATCH 1/5] bus: hisi_lpc: Don't dereference fwnode handle John Garry
2022-09-01 11:14 ` [PATCH 2/5] bus: hisi_lpc: Use devm_platform_ioremap_resource John Garry
2022-09-01 11:14 ` [PATCH 3/5] bus: hisi_lpc: Correct error code for timeout John Garry
2022-09-01 11:14 ` [PATCH 4/5] bus: hisi_lpc: Don't guard ACPI IDs with ACPI_PTR() John Garry
2022-09-01 11:14 ` [PATCH 5/5] bus: hisi_lpc: Use platform_device_register_full() John Garry
2022-09-01 17:47 ` Andy Shevchenko
2022-09-02 6:46 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6ded6f5-7132-e6e3-1f91-12deeb3b12ff@huawei.com \
--to=john.garry@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rafael.j.wysocki@intel.com \
--cc=soc@kernel.org \
--cc=xuwei5@hisilicon.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®