mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: forbidden405@outlook.com,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Yang Xiwen <forbidden405@foxmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3
Date: Sun, 25 Feb 2024 11:46:04 +0100	[thread overview]
Message-ID: <e6f5c1ec-d24d-46df-b874-49877ff099dd@linaro.org> (raw)
In-Reply-To: <20240224-dwc3-v3-1-2535fcee7f08@outlook.com>

On 24/02/2024 13:10, Yang Xiwen via B4 Relay wrote:
> +required:
> +  - compatible
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    usb {
> +        compatible = "hisilicon,hi3798mv200-dwc3";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;

You missed to implement my comments.

*ONLY WITH* them:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2024-02-25 10:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 12:10 [PATCH v3 0/2] usb: dwc3: add glue driver for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-24 12:10 ` [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 Yang Xiwen via B4 Relay
2024-02-25 10:46   ` Krzysztof Kozlowski [this message]
2024-02-24 12:10 ` [PATCH v3 2/2] usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller Yang Xiwen via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6f5c1ec-d24d-46df-b874-49877ff099dd@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=forbidden405@foxmail.com \
    --cc=forbidden405@outlook.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®