mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v3 0/2] usb: dwc3: add glue driver for Hi3798MV200
@ 2024-02-24 12:10 Yang Xiwen via B4 Relay
  2024-02-24 12:10 ` [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 Yang Xiwen via B4 Relay
  2024-02-24 12:10 ` [PATCH v3 2/2] usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller Yang Xiwen via B4 Relay
  0 siblings, 2 replies; 4+ messages in thread
From: Yang Xiwen via B4 Relay @ 2024-02-24 12:10 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Yang Xiwen
  Cc: linux-usb, linux-kernel, devicetree, Yang Xiwen

Hi3798MV200 uses DWC3 with a few more clocks and a dedicated reset.

Note xhci-histb.c can also be used. But since it's DWC3 in fact, trying
to support it with the help of DWC3 framework seems a better solution.

Hi3798CV200 can also try to migrate to this driver too. Thus we can
remove xhci-histb.c in the future.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
Changes in v3:
- binding: remove example address
- binding: remove reg (Krzysztof)
- binding: rearrange required (Krzysztof)
- binding: put additionalProperties after required (Krzysztof)
- binding: indent properly (Krzysztof)
- Link to v2: https://lore.kernel.org/r/20240224-dwc3-v2-0-8e4fcd757175@outlook.com

Changes in v2:
- remove histb-clock.h as it's deprecated.
- fix bot error (Rob Herring)
- add a dummy reg property to make simple-bus parent node happy.
  (duplicate with subnode, not used in driver)
- Link to v1: https://lore.kernel.org/r/20240224-dwc3-v1-0-7ffb2e2baa73@outlook.com

---
Yang Xiwen (2):
      dt-bindings: usb: add hisilicon,hi3798mv200-dwc3
      usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller

 .../bindings/usb/hisilicon,hi3798mv200-dwc3.yaml   | 99 ++++++++++++++++++++++
 drivers/usb/dwc3/dwc3-of-simple.c                  |  1 +
 2 files changed, 100 insertions(+)
---
base-commit: 8d3dea210042f54b952b481838c1e7dfc4ec751d
change-id: 20240217-dwc3-697828b480aa

Best regards,
-- 
Yang Xiwen <forbidden405@outlook.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3
  2024-02-24 12:10 [PATCH v3 0/2] usb: dwc3: add glue driver for Hi3798MV200 Yang Xiwen via B4 Relay
@ 2024-02-24 12:10 ` Yang Xiwen via B4 Relay
  2024-02-25 10:46   ` Krzysztof Kozlowski
  2024-02-24 12:10 ` [PATCH v3 2/2] usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller Yang Xiwen via B4 Relay
  1 sibling, 1 reply; 4+ messages in thread
From: Yang Xiwen via B4 Relay @ 2024-02-24 12:10 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Yang Xiwen
  Cc: linux-usb, linux-kernel, devicetree, Yang Xiwen

From: Yang Xiwen <forbidden405@outlook.com>

Document the DWC3 controller used by Hi3798MV200.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 .../bindings/usb/hisilicon,hi3798mv200-dwc3.yaml   | 99 ++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/hisilicon,hi3798mv200-dwc3.yaml b/Documentation/devicetree/bindings/usb/hisilicon,hi3798mv200-dwc3.yaml
new file mode 100644
index 000000000000..0c26191e9d74
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/hisilicon,hi3798mv200-dwc3.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/usb/hisilicon,hi3798mv200-dwc3.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: HiSilicon Hi3798MV200 DWC3 USB SoC controller
+
+maintainers:
+  - Yang Xiwen <forbidden405@foxmail.com>
+
+properties:
+  compatible:
+    const: hisilicon,hi3798mv200-dwc3
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
+  ranges: true
+
+  clocks:
+    items:
+      - description: Controller bus clock
+      - description: Controller suspend clock
+      - description: Controller reference clock
+      - description: Controller gm clock
+      - description: Controller gs clock
+      - description: Controller utmi clock
+      - description: Controller pipe clock
+
+  clock-names:
+    items:
+      - const: bus
+      - const: suspend
+      - const: ref
+      - const: gm
+      - const: gs
+      - const: utmi
+      - const: pipe
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: soft
+
+patternProperties:
+  '^usb@[0-9a-f]+$':
+    $ref: snps,dwc3.yaml#
+
+required:
+  - compatible
+  - ranges
+  - '#address-cells'
+  - '#size-cells'
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    usb {
+        compatible = "hisilicon,hi3798mv200-dwc3";
+        #address-cells = <1>;
+        #size-cells = <1>;
+        ranges;
+        clocks = <&clk_bus>,
+                 <&clk_suspend>,
+                 <&clk_ref>,
+                 <&clk_gm>,
+                 <&clk_gs>,
+                 <&clk_utmi>,
+                 <&clk_pipe>;
+        clock-names = "bus", "suspend", "ref", "gm", "gs", "utmi", "pipe";
+        resets = <&crg 0xb0 12>;
+        reset-names = "soft";
+
+        usb@98a0000 {
+            compatible = "snps,dwc3";
+            reg = <0x98a0000 0x10000>;
+            interrupts = <GIC_SPI 69 IRQ_TYPE_LEVEL_HIGH>;
+            clocks = <&clk_bus>,
+                     <&clk_suspend>,
+                     <&clk_ref>;
+            clock-names = "bus_early", "suspend", "ref";
+            phys = <&usb2_phy1_port2>, <&combphy0 0>;
+            phy-names = "usb2-phy", "usb3-phy";
+            maximum-speed = "super-speed";
+            dr_mode = "host";
+        };
+    };

-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v3 2/2] usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller
  2024-02-24 12:10 [PATCH v3 0/2] usb: dwc3: add glue driver for Hi3798MV200 Yang Xiwen via B4 Relay
  2024-02-24 12:10 ` [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 Yang Xiwen via B4 Relay
@ 2024-02-24 12:10 ` Yang Xiwen via B4 Relay
  1 sibling, 0 replies; 4+ messages in thread
From: Yang Xiwen via B4 Relay @ 2024-02-24 12:10 UTC (permalink / raw)
  To: Thinh Nguyen, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Yang Xiwen
  Cc: linux-usb, linux-kernel, devicetree, Yang Xiwen

From: Yang Xiwen <forbidden405@outlook.com>

Hi3798MV200 uses dwc3 controller with a few more clocks and a dedicated
resets. Use of_simple driver for it.

Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 drivers/usb/dwc3/dwc3-of-simple.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index d1539fc9eabd..158acae08af5 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -173,6 +173,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
 	{ .compatible = "sprd,sc9860-dwc3" },
 	{ .compatible = "allwinner,sun50i-h6-dwc3" },
 	{ .compatible = "hisilicon,hi3670-dwc3" },
+	{ .compatible = "hisilicon,hi3798mv200-dwc3" },
 	{ .compatible = "intel,keembay-dwc3" },
 	{ /* Sentinel */ }
 };

-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3
  2024-02-24 12:10 ` [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 Yang Xiwen via B4 Relay
@ 2024-02-25 10:46   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-02-25 10:46 UTC (permalink / raw)
  To: forbidden405, Thinh Nguyen, Greg Kroah-Hartman, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Yang Xiwen
  Cc: linux-usb, linux-kernel, devicetree

On 24/02/2024 13:10, Yang Xiwen via B4 Relay wrote:
> +required:
> +  - compatible
> +  - ranges
> +  - '#address-cells'
> +  - '#size-cells'
> +  - clocks
> +  - clock-names
> +  - resets
> +  - reset-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> +    usb {
> +        compatible = "hisilicon,hi3798mv200-dwc3";
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        ranges;

You missed to implement my comments.

*ONLY WITH* them:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-02-25 10:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 12:10 [PATCH v3 0/2] usb: dwc3: add glue driver for Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-24 12:10 ` [PATCH v3 1/2] dt-bindings: usb: add hisilicon,hi3798mv200-dwc3 Yang Xiwen via B4 Relay
2024-02-25 10:46   ` Krzysztof Kozlowski
2024-02-24 12:10 ` [PATCH v3 2/2] usb: dwc3: of-simple: Add compatible for hi3798mv200 DWC3 controller Yang Xiwen via B4 Relay

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®